From: Matthew Wilcox <willy@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
linux-mm@kvack.org, Josh Triplett <josh@joshtriplett.org>,
Matthew Wilcox <mawilcox@microsoft.com>
Subject: Re: [PATCH 1/2] mm: Make follow_pte_pmd an inline
Date: Tue, 19 Dec 2017 09:12:54 -0800 [thread overview]
Message-ID: <20171219171254.GD30842@bombadil.infradead.org> (raw)
In-Reply-To: <1513703142.1234.53.camel@perches.com>
On Tue, Dec 19, 2017 at 09:05:42AM -0800, Joe Perches wrote:
> On Tue, 2017-12-19 at 08:58 -0800, Matthew Wilcox wrote:
> > + /* (void) is needed to make gcc happy */
> > + (void) __cond_lock(*ptlp,
> > + !(res = __follow_pte_pmd(mm, address, start, end,
> > + ptepp, pmdpp, ptlp)));
>
> This seems obscure and difficult to read. Perhaps:
>
> res = __follow_pte_pmd(mm, address, start, end, ptepp, pmdpp, ptlp);
> (void)__cond_lock(*ptlp, !res);
Patch 1 moves the code. Patch 2 cleans it up ;-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-19 17:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 16:58 [PATCH 1/2] mm: Make follow_pte_pmd an inline Matthew Wilcox
2017-12-19 16:58 ` [PATCH 2/2] Introduce __cond_lock_err Matthew Wilcox
2017-12-21 21:48 ` Ross Zwisler
2017-12-21 22:00 ` Josh Triplett
2017-12-21 22:10 ` Ross Zwisler
2017-12-22 1:10 ` Matthew Wilcox
2017-12-22 4:21 ` Josh Triplett
2017-12-22 12:31 ` Matthew Wilcox
2017-12-22 13:36 ` Matthew Wilcox
2017-12-23 9:39 ` Josh Triplett
2017-12-23 13:06 ` Matthew Wilcox
2017-12-27 14:38 ` Luc Van Oostenryck
2017-12-27 14:28 ` Luc Van Oostenryck
2017-12-30 7:17 ` Matthew Wilcox
2017-12-19 17:05 ` [PATCH 1/2] mm: Make follow_pte_pmd an inline Joe Perches
2017-12-19 17:12 ` Matthew Wilcox [this message]
2017-12-21 21:29 ` Ross Zwisler
2017-12-22 1:07 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219171254.GD30842@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=dave.hansen@intel.com \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).