From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
rientjes@google.com, hannes@cmpxchg.org, guro@fb.com,
tj@kernel.org, vdavydov.dev@gmail.com
Subject: Re: [PATCH] mm,oom: Set ->signal->oom_mm to all thread groupssharing victim's memory.
Date: Sat, 6 Jan 2018 10:34:58 +0100 [thread overview]
Message-ID: <20180106093458.GA16576@dhcp22.suse.cz> (raw)
In-Reply-To: <201801061637.CCF78186.OOJFFtMVOLSHQF@I-love.SAKURA.ne.jp>
On Sat 06-01-18 16:37:17, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > On Tue 19-12-17 20:26:14, Tetsuo Handa wrote:
> > > When the OOM reaper set MMF_OOM_SKIP on the victim's mm before threads
> > > sharing that mm get ->signal->oom_mm, the comment "That thread will now
> > > get access to memory reserves since it has a pending fatal signal." no
> > > longer stands. Also, since we introduced ALLOC_OOM watermark, the comment
> > > "They don't get access to memory reserves, though, to avoid depletion of
> > > all memory." no longer stands.
> > >
> > > This patch treats all thread groups sharing the victim's mm evenly,
> > > and updates the outdated comment.
> >
> > Nack with a real life example where this matters.
>
> You did not respond to
> http://lkml.kernel.org/r/201712232341.FGC64072.VFLOOJOtFSFMHQ@I-love.SAKURA.ne.jp ,
Yes I haven't because there is simply no point continuing this
discussion. You are simply immune to any arguments.
> and I observed needless OOM-killing. Therefore, I push this patch again.
Yes, the life is tough and oom heuristic might indeed kill more tasks
for some workloads. But as long as those needless oom killing happens
for artificial workloads I am not all that much interested. Show me
some workload that is actually real and we can make the current code
more complicated. Without that my position remains.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-06 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 11:26 [PATCH] mm,oom: Set ->signal->oom_mm to all thread groups sharing victim's memory Tetsuo Handa
2017-12-19 11:40 ` Michal Hocko
2018-01-06 7:37 ` [PATCH] mm,oom: Set ->signal->oom_mm to all thread groupssharing " Tetsuo Handa
2018-01-06 9:34 ` Michal Hocko [this message]
2018-01-06 11:01 ` [PATCH] mm,oom: Set ->signal->oom_mm to all thread groupssharingvictim's memory Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106093458.GA16576@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).