Re: [PATCH v5 2/2] printk: Hide console waiter logic into helpers

Sergey Senozhatsky
2018-01-16T05:05:20Z

On (01/15/18 17:08), Petr Mladek wrote:
> > Besides the typos (which should be fixed)...
> >
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> JFYI, I have fixed the typos, updated the commit message for
> the 1st patch and pushed all into printk.git,
> branch for-4.16-console-waiter-logic, see
> https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/log/?h=for-4.16-console-waiter-logic
>
> I know that the discussion is not completely finished but it is
> somehow cycling. Sergey few times wrote that he would not block
> these patches. It is high time, I put it into linux-next. I could
> always remove it if decided in the discussion.

Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

at least we have preemption out of printk->user way (one of the
things I tried to tell you), which looks more like a step forward
to me personally.

p.s. the printk is still pretty far from what I want it to be.
vprintk_emit() still can cause disturbance and damage in
pretty unrelated places. e.g. hung tasks on console_sem,
and so on. I'm going to keep my out-of-tree patches alive,
may be they will be merged upstream in some form or another
may be not.

-ss