Re: [PATCH v5 2/2] printk: Hide console waiter logic into helpers

Petr Mladek
2018-01-15T16:08:30Z

On Fri 2018-01-12 11:36:27, Steven Rostedt wrote:
> On Fri, 12 Jan 2018 17:08:37 +0100
> Petr Mladek <pmladek@suse.com> wrote:
> > >From f67f70d910d9cf310a7bc73e97bf14097d31b059 Mon Sep 17 00:00:00 2001
> > From: Petr Mladek <pmladek@suse.com>
> > Date: Fri, 22 Dec 2017 18:58:46 +0100
> > Subject: [PATCH v6 2/4] printk: Hide console waiter logic into helpers
> >
> > The commit ("printk: Add console owner and waiter logic to load balance
> > console writes") made vprintk_emit() and console_unlock() even more
> > complicated.
> >
> > This patch extracts the new code into 3 helper functions. They should
> > help to keep it rather self-contained. It will be easier to use and
> > maintain.
> >
> > This patch just shuffles the existing code. It does not change
> > the functionality.
> >
> Besides the typos (which should be fixed)...
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

JFYI, I have fixed the typos, updated the commit message for
the 1st patch and pushed all into printk.git,
branch for-4.16-console-waiter-logic, see
https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/log/?h=for-4.16-console-waiter-logic

I know that the discussion is not completely finished but it is
somehow cycling. Sergey few times wrote that he would not block
these patches. It is high time, I put it into linux-next. I could
always remove it if decided in the discussion.

Best Regards,
Petr