From: Michal Hocko <mhocko@kernel.org>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
pasha.tatashin@oracle.com
Subject: Re: Memory hotplug not increasing the total RAM
Date: Tue, 30 Jan 2018 10:16:00 +0100 [thread overview]
Message-ID: <20180130091600.GA26445@dhcp22.suse.cz> (raw)
In-Reply-To: <20180130083006.GB1245@in.ibm.com>
On Tue 30-01-18 14:00:06, Bharata B Rao wrote:
> Hi,
>
> With the latest upstream, I see that memory hotplug is not working
> as expected. The hotplugged memory isn't seen to increase the total
> RAM pages. This has been observed with both x86 and Power guests.
>
> 1. Memory hotplug code intially marks pages as PageReserved via
> __add_section().
> 2. Later the struct page gets cleared in __init_single_page().
> 3. Next online_pages_range() increments totalram_pages only when
> PageReserved is set.
You are right. I have completely forgot about this late struct page
initialization during onlining. memory hotplug really doesn't want
zeroying. Let me think about a fix.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-30 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 8:30 Memory hotplug not increasing the total RAM Bharata B Rao
2018-01-30 9:16 ` Michal Hocko [this message]
2018-01-30 9:28 ` Michal Hocko
2018-01-30 9:53 ` Bharata B Rao
2018-01-30 10:11 ` Michal Hocko
2018-01-30 18:11 ` Pavel Tatashin
2018-01-30 18:29 ` Michal Hocko
2018-01-30 19:12 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130091600.GA26445@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=bharata@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).