Re: [RFC] Per file OOM badness

roger
2018-01-19T10:02:35Z

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

On 2018a1'01ae??19ae?JPY 16:25, Michal Hocko wrote:
> [removed the broken quoting - please try to use an email client which
> doesn't mess up the qouted text]
>
> On Fri 19-01-18 06:01:26, He, Roger wrote:
> [...]
>> I think you are misunderstanding here.
>> Actually for now, the memory in TTM Pools already has mm_shrink which is implemented in ttm_pool_mm_shrink_init.
>> And here the memory we want to make it contribute to OOM badness is not in TTM Pools.
>> Because when TTM buffer allocation success, the memory already is removed from TTM Pools.
>
> I have no idea what TTM buffers are. But this smells like something
> rather specific to the particular subsytem. And my main objection here
> is that struct file is not a proper vehicle to carry such an
> information. So whatever the TTM subsystem does it should contribute to
> generic counters rather than abuse fd because it happens to use it to
> communicate with userspace.
>
A A got it. thanks.
>

[-- Attachment #2: Type: text/html, Size: 1627 bytes --]