From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id F156D6B0005 for ; Thu, 8 Feb 2018 21:55:25 -0500 (EST) Received: by mail-pg0-f72.google.com with SMTP id k6so2896244pgt.15 for ; Thu, 08 Feb 2018 18:55:25 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id g1-v6sor412227plb.105.2018.02.08.18.55.24 for (Google Transport Security); Thu, 08 Feb 2018 18:55:24 -0800 (PST) Date: Fri, 9 Feb 2018 11:55:20 +0900 From: Sergey Senozhatsky Subject: Re: [PATCH 1/2] zsmalloc: introduce zs_huge_object() function Message-ID: <20180209025520.GA3423@jagdpanzerIV> References: <20180207092919.19696-1-sergey.senozhatsky@gmail.com> <20180207092919.19696-2-sergey.senozhatsky@gmail.com> <20180208163006.GB17354@rapoport-lnx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180208163006.GB17354@rapoport-lnx> Sender: owner-linux-mm@kvack.org List-ID: To: Mike Rapoport Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky On (02/08/18 18:30), Mike Rapoport wrote: [..] > > > > +/* > > + * Check if the object's size falls into huge_class area. We must take > > + * ZS_HANDLE_SIZE into account and test the actual size we are going to > > + * use up. zs_malloc() unconditionally adds handle size before it performs > > + * size_class lookup, so we may endup in a huge class yet zs_huge_object() > > + * returned 'false'. > > + */ > > Can you please reformat this comment as kernel-doc? Is this - Documentation/doc-guide/kernel-doc.rst - the right thing to use as a reference? -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org