From: Matthew Wilcox <willy@infradead.org>
To: Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: Michal Hocko <mhocko@suse.com>, Laura Abbott <labbott@redhat.com>,
linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")
Date: Fri, 9 Feb 2018 06:07:28 -0800 [thread overview]
Message-ID: <20180209140728.GC16666@bombadil.infradead.org> (raw)
In-Reply-To: <2DB8D5E5-0955-47CF-A142-09A5BA71DF70@canonical.com>
On Fri, Feb 09, 2018 at 05:12:56PM +0800, Kai Heng Feng wrote:
> Hi Matthew,
>
> > On Feb 9, 2018, at 12:08 PM, Matthew Wilcox <willy@infradead.org> wrote:
> > Alternatively, try this. It passes in GFP_DMA32 from vmalloc_32,
> > regardless of whether ZONE_DMA32 exists or not. If ZONE_DMA32 doesn't
> > exist, then we clear it in __vmalloc_area_node(), after using it to
> > determine that we shouldn't set __GFP_HIGHMEM.
>
> IIUC, I need to let drivers/media drivers start using vmalloc_32() with your
> patch, right?
Hopefully those that need to already are. Otherwise they're broken
on 64-bit. I do see several places already using vmalloc_32().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-02-09 14:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 6:29 Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly") Kai Heng Feng
2018-02-08 13:06 ` Matthew Wilcox
2018-02-08 17:56 ` Laura Abbott
2018-02-08 18:18 ` Matthew Wilcox
2018-02-08 18:34 ` Laura Abbott
2018-02-08 23:20 ` Matthew Wilcox
2018-02-09 4:08 ` Matthew Wilcox
2018-02-09 9:12 ` Kai Heng Feng
2018-02-09 14:07 ` Matthew Wilcox [this message]
2018-02-11 9:26 ` Michal Hocko
2018-02-11 11:28 ` Matthew Wilcox
2018-02-11 12:05 ` Matthew Wilcox
2018-02-11 23:51 ` Matthew Wilcox
2018-02-14 14:04 ` Michal Hocko
2018-02-12 9:50 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209140728.GC16666@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=kai.heng.feng@canonical.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).