From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f199.google.com (mail-qk0-f199.google.com [209.85.220.199]) by kanga.kvack.org (Postfix) with ESMTP id B33546B0005 for ; Fri, 9 Feb 2018 11:23:55 -0500 (EST) Received: by mail-qk0-f199.google.com with SMTP id f11so6988562qkm.1 for ; Fri, 09 Feb 2018 08:23:55 -0800 (PST) Received: from mx1.redhat.com (mx3-rdu2.redhat.com. [66.187.233.73]) by mx.google.com with ESMTPS id s3si2442819qkc.334.2018.02.09.08.23.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 08:23:54 -0800 (PST) Date: Fri, 9 Feb 2018 18:23:53 +0200 From: "Michael S. Tsirkin" Subject: Re: [PATCH] mm/page_poison: move PAGE_POISON to page_poison.c Message-ID: <20180209180755-mutt-send-email-mst@kernel.org> References: <1518163694-27155-1-git-send-email-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518163694-27155-1-git-send-email-wei.w.wang@intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Wei Wang Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org On Fri, Feb 09, 2018 at 04:08:14PM +0800, Wei Wang wrote: > The PAGE_POISON macro is used in page_poison.c only, so avoid exporting > it. Also remove the "mm/debug-pagealloc.c" related comment, which is > obsolete. > > Signed-off-by: Wei Wang > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Michael S. Tsirkin > --- > include/linux/poison.h | 7 ------- > mm/page_poison.c | 6 ++++++ > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/include/linux/poison.h b/include/linux/poison.h > index 15927eb..348bf67 100644 > --- a/include/linux/poison.h > +++ b/include/linux/poison.h > @@ -30,13 +30,6 @@ > */ > #define TIMER_ENTRY_STATIC ((void *) 0x300 + POISON_POINTER_DELTA) > > -/********** mm/debug-pagealloc.c **********/ > -#ifdef CONFIG_PAGE_POISONING_ZERO > -#define PAGE_POISON 0x00 > -#else > -#define PAGE_POISON 0xaa > -#endif > - > /********** mm/page_alloc.c ************/ > > #define TAIL_MAPPING ((void *) 0x400 + POISON_POINTER_DELTA) My question is, why are these macros kept in a single header. Is it so it's easy to figure out source of a crash by looking at the data and locating it in the file? If so we should keep it in the header, but fix the comment. If no there are more macros to move out, like flex array ones. > diff --git a/mm/page_poison.c b/mm/page_poison.c > index e83fd44..8aaf076 100644 > --- a/mm/page_poison.c > +++ b/mm/page_poison.c > @@ -7,6 +7,12 @@ > #include > #include > > +#ifdef CONFIG_PAGE_POISONING_ZERO > +#define PAGE_POISON 0x00 > +#else > +#define PAGE_POISON 0xaa > +#endif > + > static bool want_page_poisoning __read_mostly; > > static int early_page_poison_param(char *buf) > -- > 2.7.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org