From: Matthew Wilcox <willy@infradead.org>
To: Mario Leinweber <marioleinweber@web.de>
Cc: akpm@linux-foundation.org, mingo@kernel.org,
kirill.shutemov@linux.intel.com, aneesh.kumar@linux.vnet.ibm.com,
mhocko@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/gup: Fixed coding style error and warnings.
Date: Tue, 13 Feb 2018 11:36:49 -0800 [thread overview]
Message-ID: <20180213193649.GA2663@bombadil.infradead.org> (raw)
In-Reply-To: <20180213191722.11228-1-marioleinweber@web.de>
On Tue, Feb 13, 2018 at 02:17:22PM -0500, Mario Leinweber wrote:
> if (flags & FOLL_SPLIT && PageTransCompound(page)) {
> int ret;
> +
> get_page(page);
Hi Mario,
Thanks for your patch, but this kind of change to the Linux core is not
generally welcomed. There are a lot of people working on the core and
having whitespace changes conflict with real changes isn't a good use of
people's time. You can practice whitespace changes in drivers/staging
before graduating to patches which change functionality.
Hope to see you back soon!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2018-02-13 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 19:17 [PATCH] mm/gup: Fixed coding style error and warnings Mario Leinweber
2018-02-13 19:32 ` Joe Perches
2018-02-13 19:36 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213193649.GA2663@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marioleinweber@web.de \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).