From: Matthew Wilcox <willy@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-mm@kvack.org, Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v2 3/8] Convert virtio_console to kvzalloc_struct
Date: Wed, 14 Feb 2018 12:28:35 -0800 [thread overview]
Message-ID: <20180214202835.GE20627@bombadil.infradead.org> (raw)
In-Reply-To: <1518639587.3678.25.camel@perches.com>
On Wed, Feb 14, 2018 at 12:19:47PM -0800, Joe Perches wrote:
> On Wed, 2018-02-14 at 12:11 -0800, Matthew Wilcox wrote:
> > */
> > - buf = kmalloc(sizeof(*buf) + sizeof(struct scatterlist) * pages,
> > - GFP_KERNEL);
> > + buf = kvzalloc_struct(buf, sg, pages, GFP_KERNEL);
> > if (!buf)
>
> kvfree?
Yes, that would also need to be done. The point of these last six
patches was to show the API in use, not for applying.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-02-14 20:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 20:11 [PATCH v2 0/8] Add kvzalloc_struct to complement kvzalloc_array Matthew Wilcox
2018-02-14 20:11 ` [PATCH v2 1/8] mm: Add kernel-doc for kvfree Matthew Wilcox
2018-02-14 20:11 ` [PATCH v2 2/8] mm: Add kvmalloc_ab_c and kvzalloc_struct Matthew Wilcox
2018-02-14 20:45 ` Joe Perches
2018-02-14 21:12 ` Matthew Wilcox
2018-02-14 21:24 ` Joe Perches
2018-02-14 21:27 ` Joe Perches
2018-02-14 21:29 ` Matthew Wilcox
2018-02-14 23:58 ` Andrew Morton
2018-02-15 3:40 ` Matthew Wilcox
2018-02-15 17:36 ` Matthew Wilcox
2018-02-14 20:11 ` [PATCH v2 3/8] Convert virtio_console to kvzalloc_struct Matthew Wilcox
2018-02-14 20:19 ` Joe Perches
2018-02-14 20:28 ` Matthew Wilcox [this message]
2018-02-14 20:30 ` Joe Perches
2018-02-14 20:11 ` [PATCH v2 4/8] Convert dax device " Matthew Wilcox
2018-02-14 20:11 ` [PATCH v2 5/8] Convert infiniband uverbs " Matthew Wilcox
2018-02-14 20:11 ` [PATCH v2 6/8] Convert v4l2 event " Matthew Wilcox
2018-02-14 20:11 ` [PATCH v2 7/8] Convert vhost " Matthew Wilcox
2018-02-14 20:11 ` [PATCH v2 8/8] Convert jffs2 acl " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214202835.GE20627@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).