From: Christoph Lameter <cl@linux.com>
To: Mel Gorman <mel@skynet.ie>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-rdma@vger.kernel.org,
akpm@linux-foundation.org,
Thomas Schoebel-Theuer <tst@schoebel-theuer.de>,
andi@firstfloor.org, Rik van Riel <riel@redhat.com>,
Michal Hocko <mhocko@kernel.org>, Guy Shattah <sguy@mellanox.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Michal Nazarewicz <mina86@mina86.com>,
Vlastimil Babka <vbabka@suse.cz>,
David Nellans <dnellans@nvidia.com>,
Laura Abbott <labbott@redhat.com>, Pavel Machek <pavel@ucw.cz>,
Dave Hansen <dave.hansen@intel.com>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: [RFC 2/2] Page order diagnostics
Date: Fri, 16 Feb 2018 10:01:12 -0600 [thread overview]
Message-ID: <20180216160121.583566579@linux.com> (raw)
In-Reply-To: 20180216160110.641666320@linux.com
[-- Attachment #1: order_stats --]
[-- Type: text/plain, Size: 5572 bytes --]
It is beneficial to know about the contiguous memory segments
available on a system and the number of allocations failing
for each page order.
This patch adds details per order statistics to /proc/meminfo
so the current memory use can be determined.
Also adds counters to /proc/vmstat to show allocation
failures for each page order.
Signed-off-by: Christoph Laeter <cl@linux.com>
Index: linux/include/linux/mmzone.h
===================================================================
--- linux.orig/include/linux/mmzone.h
+++ linux/include/linux/mmzone.h
@@ -185,6 +185,10 @@ enum node_stat_item {
NR_VMSCAN_IMMEDIATE, /* Prioritise for reclaim when writeback ends */
NR_DIRTIED, /* page dirtyings since bootup */
NR_WRITTEN, /* page writings since bootup */
+#ifdef CONFIG_ORDER_STATS
+ NR_ORDER,
+ NR_ORDER_MAX = NR_ORDER + MAX_ORDER - 1,
+#endif
NR_VM_NODE_STAT_ITEMS
};
Index: linux/mm/page_alloc.c
===================================================================
--- linux.orig/mm/page_alloc.c
+++ linux/mm/page_alloc.c
@@ -828,6 +828,10 @@ static inline void __free_one_page(struc
VM_BUG_ON_PAGE(pfn & ((1 << order) - 1), page);
VM_BUG_ON_PAGE(bad_range(zone, page), page);
+#ifdef CONFIG_ORDER_STATS
+ dec_node_page_state(page, NR_ORDER + order);
+#endif
+
continue_merging:
while (order < max_order - 1) {
buddy_pfn = __find_buddy_pfn(pfn, order);
@@ -1285,6 +1289,9 @@ static void __init __free_pages_boot_cor
page_zone(page)->managed_pages += nr_pages;
set_page_refcounted(page);
__free_pages(page, order);
+#ifdef CONFIG_ORDER_STATS
+ inc_node_page_state(page, NR_ORDER + order);
+#endif
}
#if defined(CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID) || \
@@ -1855,6 +1862,9 @@ struct page *__rmqueue_smallest(struct z
rmv_page_order(page);
area->nr_free--;
expand(zone, page, order, current_order, area, migratetype);
+#ifdef CONFIG_ORDER_STATS
+ inc_node_page_state(page, NR_ORDER + order);
+#endif
set_pcppage_migratetype(page, migratetype);
return page;
}
@@ -4169,6 +4179,11 @@ nopage:
fail:
warn_alloc(gfp_mask, ac->nodemask,
"page allocation failure: order:%u", order);
+
+#ifdef CONFIG_ORDER_STATS
+ count_vm_event(ORDER0_ALLOC_FAIL + order);
+#endif
+
got_pg:
return page;
}
Index: linux/fs/proc/meminfo.c
===================================================================
--- linux.orig/fs/proc/meminfo.c
+++ linux/fs/proc/meminfo.c
@@ -51,6 +51,7 @@ static int meminfo_proc_show(struct seq_
long available;
unsigned long pages[NR_LRU_LISTS];
int lru;
+ int order;
si_meminfo(&i);
si_swapinfo(&i);
@@ -155,6 +156,11 @@ static int meminfo_proc_show(struct seq_
global_zone_page_state(NR_FREE_CMA_PAGES));
#endif
+#ifdef CONFIG_ORDER_STATS
+ for (order= 0; order < MAX_ORDER; order++)
+ seq_printf(m, "Order%2d Pages: %5lu\n",
+ order, global_node_page_state(NR_ORDER + order));
+#endif
hugetlb_report_meminfo(m);
arch_report_meminfo(m);
Index: linux/mm/Kconfig
===================================================================
--- linux.orig/mm/Kconfig
+++ linux/mm/Kconfig
@@ -752,6 +752,15 @@ config PERCPU_STATS
information includes global and per chunk statistics, which can
be used to help understand percpu memory usage.
+config ORDER_STATS
+ bool "Statistics for different sized allocations"
+ default n
+ help
+ Create statistics about the contiguous memory segments allocated
+ through the page allocator. This creates statistics about the
+ memory segments in use in /proc/meminfo and the node meminfo files
+ as well as allocation failure statistics in /proc/vmstat.
+
config GUP_BENCHMARK
bool "Enable infrastructure for get_user_pages_fast() benchmarking"
default n
Index: linux/include/linux/vm_event_item.h
===================================================================
--- linux.orig/include/linux/vm_event_item.h
+++ linux/include/linux/vm_event_item.h
@@ -111,6 +111,10 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS
SWAP_RA,
SWAP_RA_HIT,
#endif
+#ifdef CONFIG_ORDER_STATS
+ ORDER0_ALLOC_FAIL,
+ ORDER_MAX_FAIL = ORDER0_ALLOC_FAIL + MAX_ORDER -1,
+#endif
NR_VM_EVENT_ITEMS
};
Index: linux/mm/vmstat.c
===================================================================
--- linux.orig/mm/vmstat.c
+++ linux/mm/vmstat.c
@@ -1289,6 +1289,52 @@ const char * const vmstat_text[] = {
"swap_ra",
"swap_ra_hit",
#endif
+#ifdef CONFIG_ORDER_STATS
+ "order0_failure",
+ "order1_failure",
+ "order2_failure",
+ "order3_failure",
+ "order4_failure",
+ "order5_failure",
+ "order6_failure",
+ "order7_failure",
+ "order8_failure",
+ "order9_failure",
+ "order10_failure",
+#ifdef CONFIG_FORCE_MAX_ZONEORDER
+#if MAX_ORDER > 11
+ "order11_failure"
+#endif
+#if MAX_ORDER > 12
+ "order12_failure"
+#endif
+#if MAX_ORDER > 13
+ "order13_failure"
+#endif
+#if MAX_ORDER > 14
+ "order14_failure"
+#endif
+#if MAX_ORDER > 15
+ "order15_failure"
+#endif
+#if MAX_ORDER > 16
+ "order16_failure"
+#endif
+#if MAX_ORDER > 17
+ "order17_failure"
+#endif
+#if MAX_ORDER > 18
+ "order18_failure"
+#endif
+#if MAX_ORDER > 19
+ "order19_failure"
+#endif
+#if MAX_ORDER > 20
+#error Please add more lines...
+#endif
+
+#endif /* CONFIG_FORCE_MAX_ZONEORDER */
+#endif /* CONFIG_ORDER_STATS */
#endif /* CONFIG_VM_EVENTS_COUNTERS */
};
#endif /* CONFIG_PROC_FS || CONFIG_SYSFS || CONFIG_NUMA */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-02-16 16:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 16:01 [RFC 0/2] Larger Order Protection V1 Christoph Lameter
2018-02-16 16:01 ` [RFC 1/2] Protect larger order pages from breaking up Christoph Lameter
2018-02-16 17:03 ` Andi Kleen
2018-02-16 18:25 ` Christopher Lameter
2018-02-16 18:02 ` Randy Dunlap
2018-02-17 16:07 ` Mike Rapoprt
2018-02-16 18:59 ` Mike Kravetz
2018-02-16 20:13 ` Christopher Lameter
2018-02-18 9:00 ` Guy Shattah
2018-02-16 19:01 ` Dave Hansen
2018-02-16 20:15 ` Christopher Lameter
2018-02-16 21:08 ` Dave Hansen
2018-02-16 21:43 ` Matthew Wilcox
2018-02-16 21:47 ` Dave Hansen
2018-02-19 10:19 ` Mel Gorman
2018-02-19 14:42 ` Michal Hocko
2018-02-19 15:09 ` Christopher Lameter
2018-02-22 21:19 ` Thomas Schoebel-Theuer
2018-02-22 21:53 ` Zi Yan
2018-02-23 2:01 ` Christopher Lameter
2018-02-23 2:16 ` Zi Yan
2018-02-23 2:45 ` Christopher Lameter
2018-02-23 9:59 ` Mel Gorman
2018-02-16 16:01 ` Christoph Lameter [this message]
2018-02-17 21:17 ` [RFC 2/2] Page order diagnostics Pavel Machek
2018-02-19 14:54 ` Christopher Lameter
2018-02-16 18:27 ` [RFC 0/2] Larger Order Protection V1 Christopher Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216160121.583566579@linux.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dave.hansen@intel.com \
--cc=dnellans@nvidia.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=labbott@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mel@skynet.ie \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mina86@mina86.com \
--cc=pavel@ucw.cz \
--cc=riel@redhat.com \
--cc=sguy@mellanox.com \
--cc=tst@schoebel-theuer.de \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).