From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f71.google.com (mail-pl0-f71.google.com [209.85.160.71]) by kanga.kvack.org (Postfix) with ESMTP id 2E2F46B0008 for ; Fri, 16 Feb 2018 16:58:53 -0500 (EST) Received: by mail-pl0-f71.google.com with SMTP id a14so3012924pls.8 for ; Fri, 16 Feb 2018 13:58:53 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id c11-v6si3848423plo.675.2018.02.16.13.58.52 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Feb 2018 13:58:52 -0800 (PST) Date: Fri, 16 Feb 2018 13:58:48 -0800 From: Matthew Wilcox Subject: Re: [PATCH v21 1/5] xbitmap: Introduce xbitmap Message-ID: <20180216215848.GB32655@bombadil.infradead.org> References: <1515496262-7533-1-git-send-email-wei.w.wang@intel.com> <1515496262-7533-2-git-send-email-wei.w.wang@intel.com> <20180216183032.GA7439@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Andy Shevchenko Cc: Wei Wang , virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm , "Michael S. Tsirkin" , mhocko@kernel.org, Andrew Morton , Matthew Wilcox , david@redhat.com, Tetsuo Handa , cornelia.huck@de.ibm.com, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, Paolo Bonzini , liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com On Fri, Feb 16, 2018 at 11:45:51PM +0200, Andy Shevchenko wrote: > Now, the question about test case. Why do you heavily use BUG_ON? > Isn't resulting statistics enough? No. If any of those tests fail, we want to stop dead. They'll lead to horrendous bugs throughout the kernel if they're wrong. I think more of the in-kernel test suite should stop dead instead of printing a warning. Would you want to boot a machine which has a known bug in the page cache, for example? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org