From: Pavel Machek <pavel@ucw.cz>
To: Christoph Lameter <cl@linux.com>
Cc: Mel Gorman <mel@skynet.ie>, Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-rdma@vger.kernel.org,
akpm@linux-foundation.org,
Thomas Schoebel-Theuer <tst@schoebel-theuer.de>,
andi@firstfloor.org, Rik van Riel <riel@redhat.com>,
Michal Hocko <mhocko@kernel.org>, Guy Shattah <sguy@mellanox.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Michal Nazarewicz <mina86@mina86.com>,
Vlastimil Babka <vbabka@suse.cz>,
David Nellans <dnellans@nvidia.com>,
Laura Abbott <labbott@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [RFC 2/2] Page order diagnostics
Date: Sat, 17 Feb 2018 22:17:25 +0100 [thread overview]
Message-ID: <20180217211725.GA9640@amd> (raw)
In-Reply-To: <20180216160121.583566579@linux.com>
[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]
Hi!
> @@ -1289,6 +1289,52 @@ const char * const vmstat_text[] = {
> "swap_ra",
> "swap_ra_hit",
> #endif
> +#ifdef CONFIG_ORDER_STATS
> + "order0_failure",
> + "order1_failure",
> + "order2_failure",
> + "order3_failure",
> + "order4_failure",
> + "order5_failure",
> + "order6_failure",
> + "order7_failure",
> + "order8_failure",
> + "order9_failure",
> + "order10_failure",
> +#ifdef CONFIG_FORCE_MAX_ZONEORDER
> +#if MAX_ORDER > 11
> + "order11_failure"
> +#endif
> +#if MAX_ORDER > 12
> + "order12_failure"
> +#endif
> +#if MAX_ORDER > 13
> + "order13_failure"
> +#endif
> +#if MAX_ORDER > 14
> + "order14_failure"
> +#endif
> +#if MAX_ORDER > 15
> + "order15_failure"
> +#endif
> +#if MAX_ORDER > 16
> + "order16_failure"
> +#endif
> +#if MAX_ORDER > 17
> + "order17_failure"
> +#endif
> +#if MAX_ORDER > 18
> + "order18_failure"
> +#endif
> +#if MAX_ORDER > 19
> + "order19_failure"
> +#endif
I don't think this does what you want it to do. Commas are missing.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-02-17 21:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 16:01 [RFC 0/2] Larger Order Protection V1 Christoph Lameter
2018-02-16 16:01 ` [RFC 1/2] Protect larger order pages from breaking up Christoph Lameter
2018-02-16 17:03 ` Andi Kleen
2018-02-16 18:25 ` Christopher Lameter
2018-02-16 18:02 ` Randy Dunlap
2018-02-17 16:07 ` Mike Rapoprt
2018-02-16 18:59 ` Mike Kravetz
2018-02-16 20:13 ` Christopher Lameter
2018-02-18 9:00 ` Guy Shattah
2018-02-16 19:01 ` Dave Hansen
2018-02-16 20:15 ` Christopher Lameter
2018-02-16 21:08 ` Dave Hansen
2018-02-16 21:43 ` Matthew Wilcox
2018-02-16 21:47 ` Dave Hansen
2018-02-19 10:19 ` Mel Gorman
2018-02-19 14:42 ` Michal Hocko
2018-02-19 15:09 ` Christopher Lameter
2018-02-22 21:19 ` Thomas Schoebel-Theuer
2018-02-22 21:53 ` Zi Yan
2018-02-23 2:01 ` Christopher Lameter
2018-02-23 2:16 ` Zi Yan
2018-02-23 2:45 ` Christopher Lameter
2018-02-23 9:59 ` Mel Gorman
2018-02-16 16:01 ` [RFC 2/2] Page order diagnostics Christoph Lameter
2018-02-17 21:17 ` Pavel Machek [this message]
2018-02-19 14:54 ` Christopher Lameter
2018-02-16 18:27 ` [RFC 0/2] Larger Order Protection V1 Christopher Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180217211725.GA9640@amd \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux.com \
--cc=dave.hansen@intel.com \
--cc=dnellans@nvidia.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=labbott@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mel@skynet.ie \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mina86@mina86.com \
--cc=riel@redhat.com \
--cc=sguy@mellanox.com \
--cc=tst@schoebel-theuer.de \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).