From: Matthew Wilcox <willy@infradead.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: mhocko@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
rientjes@google.com, hannes@cmpxchg.org, guro@fb.com,
tj@kernel.org, vdavydov.dev@gmail.com,
torvalds@linux-foundation.org
Subject: Re: [PATCH] mm,page_alloc: wait for oom_lock than back off
Date: Tue, 20 Feb 2018 05:40:53 -0800 [thread overview]
Message-ID: <20180220134052.GD21243@bombadil.infradead.org> (raw)
In-Reply-To: <201802202232.IEC26597.FOQtMFOFJHOSVL@I-love.SAKURA.ne.jp>
On Tue, Feb 20, 2018 at 10:32:56PM +0900, Tetsuo Handa wrote:
>
> - /*
> - * Acquire the oom lock. If that fails, somebody else is
> - * making progress for us.
> - */
> - if (!mutex_trylock(&oom_lock)) {
> + if (mutex_lock_killable(&oom_lock)) {
> *did_some_progress = 1;
> schedule_timeout_uninterruptible(1);
> return NULL;
It looks odd to mutex_lock_killable() and then
schedule_timeout_uninterruptible(). Why not schedule_timeout_killable()?
If someone's sent a fatal signal, why delay for one jiffy?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-02-20 13:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 13:46 [PATCH] mm,oom: Don't call schedule_timeout_killable() with oom_lock held Tetsuo Handa
2018-01-23 8:38 ` Michal Hocko
2018-01-23 12:07 ` Tetsuo Handa
2018-01-23 12:42 ` Michal Hocko
2018-01-24 13:28 ` Tetsuo Handa
2018-02-13 11:58 ` Tetsuo Handa
2018-02-20 13:32 ` [PATCH] mm,page_alloc: wait for oom_lock than back off Tetsuo Handa
2018-02-20 13:40 ` Matthew Wilcox [this message]
2018-02-20 14:12 ` Tetsuo Handa
2018-02-20 14:49 ` Michal Hocko
2018-02-21 14:27 ` Tetsuo Handa
2018-02-22 13:06 ` Michal Hocko
2018-02-24 8:00 ` [PATCH v2] " Tetsuo Handa
2018-02-26 9:27 ` Michal Hocko
2018-02-26 10:58 ` Tetsuo Handa
2018-02-26 12:19 ` Michal Hocko
2018-02-26 13:16 ` Tetsuo Handa
2018-03-02 11:10 ` [PATCH v3] " Tetsuo Handa
2018-03-02 14:10 ` Michal Hocko
2018-03-03 3:15 ` Tetsuo Handa
2018-03-21 10:39 ` Tetsuo Handa
2018-03-21 11:21 ` Michal Hocko
2018-03-21 11:35 ` Tetsuo Handa
2018-03-21 12:00 ` Michal Hocko
2018-03-21 12:20 ` Tetsuo Handa
2018-03-21 12:31 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220134052.GD21243@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).