linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Christopher Lameter <cl@linux.com>
Cc: ? ? <mordorw@hotmail.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] slab: fix /proc/slabinfo alignment
Date: Tue, 20 Feb 2018 08:11:39 -0800	[thread overview]
Message-ID: <20180220161139.GH21243@bombadil.infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1802201004480.29180@nuc-kabylake>

On Tue, Feb 20, 2018 at 10:05:23AM -0600, Christopher Lameter wrote:
> On Tue, 20 Feb 2018, Matthew Wilcox wrote:
> 
> > On Tue, Feb 20, 2018 at 08:56:11AM -0600, Christopher Lameter wrote:
> > > On Tue, 20 Feb 2018, ? ? wrote:
> > >
> > > > /proc/slabinfo is not aligned, it is difficult to read, so correct it
> > >
> > > How does it look on a terminal with 80 characters per line?
> >
> > That ship sailed long ago ...
> >
> > kmalloc-8192         433    435   8192    1    2 : tunables    8    4    0 : sla
> > bdata    433    435      0
> >
> > (I put in a manual carriage return at 80 columns for those not reading on
> > an 80 column terminal).
> 
> Well yes but if someone is fixing things then the 80 character issue also
> should be fixed.

I don't think it's fixable; there's just too much information per slab.
Anyway, I preferred the solution you & I were working on to limit the
length of names to 16 bytes, except for the cgroup slabs.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2018-02-20 16:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20  2:29 [PATCH] slab: fix /proc/slabinfo alignment ? ?
2018-02-20  8:49 ` Michal Hocko
2018-02-20 14:56 ` Christopher Lameter
2018-02-20 15:04   ` Matthew Wilcox
2018-02-20 16:05     ` Christopher Lameter
2018-02-20 16:11       ` Matthew Wilcox [this message]
2018-02-20 16:23         ` Christopher Lameter
2018-02-20 18:36           ` Matthew Wilcox
2018-02-20 18:43             ` Christopher Lameter
2018-02-20 19:19               ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180220161139.GH21243@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=cl@linux.com \
    --cc=linux-mm@kvack.org \
    --cc=mordorw@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).