From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id 7E8ED6B0008 for ; Tue, 20 Feb 2018 11:11:42 -0500 (EST) Received: by mail-pg0-f72.google.com with SMTP id v8so5551992pgs.9 for ; Tue, 20 Feb 2018 08:11:42 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id g10si5066702pgp.433.2018.02.20.08.11.41 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Feb 2018 08:11:41 -0800 (PST) Date: Tue, 20 Feb 2018 08:11:39 -0800 From: Matthew Wilcox Subject: Re: [PATCH] slab: fix /proc/slabinfo alignment Message-ID: <20180220161139.GH21243@bombadil.infradead.org> References: <20180220150449.GF21243@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Christopher Lameter Cc: ? ? , "linux-mm@kvack.org" On Tue, Feb 20, 2018 at 10:05:23AM -0600, Christopher Lameter wrote: > On Tue, 20 Feb 2018, Matthew Wilcox wrote: > > > On Tue, Feb 20, 2018 at 08:56:11AM -0600, Christopher Lameter wrote: > > > On Tue, 20 Feb 2018, ? ? wrote: > > > > > > > /proc/slabinfo is not aligned, it is difficult to read, so correct it > > > > > > How does it look on a terminal with 80 characters per line? > > > > That ship sailed long ago ... > > > > kmalloc-8192 433 435 8192 1 2 : tunables 8 4 0 : sla > > bdata 433 435 0 > > > > (I put in a manual carriage return at 80 columns for those not reading on > > an 80 column terminal). > > Well yes but if someone is fixing things then the 80 character issue also > should be fixed. I don't think it's fixable; there's just too much information per slab. Anyway, I preferred the solution you & I were working on to limit the length of names to 16 bytes, except for the cgroup slabs. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org