From: Baoquan He <bhe@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, dave.hansen@intel.com,
linux-mm@kvack.org, kirill.shutemov@linux.intel.com,
mhocko@suse.com, tglx@linutronix.de
Subject: Re: [PATCH v2 1/3] mm/sparse: Add a static variable nr_present_sections
Date: Fri, 23 Feb 2018 07:56:39 +0800 [thread overview]
Message-ID: <20180222235639.GD693@localhost.localdomain> (raw)
In-Reply-To: <20180222132441.51a8eae9e9656a82a2161070@linux-foundation.org>
On 02/22/18 at 01:24pm, Andrew Morton wrote:
> On Thu, 22 Feb 2018 17:11:28 +0800 Baoquan He <bhe@redhat.com> wrote:
>
> > It's used to record how many memory sections are marked as present
> > during system boot up, and will be used in the later patch.
> >
> > --- a/mm/sparse.c
> > +++ b/mm/sparse.c
> > @@ -202,6 +202,7 @@ static inline int next_present_section_nr(int section_nr)
> > (section_nr <= __highest_present_section_nr)); \
> > section_nr = next_present_section_nr(section_nr))
> >
> > +static int nr_present_sections;
>
> I think this could be __initdata.
>
> A nice comment explaining why it exists would be nice.
Thanks, I will update as you suggested.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-02-22 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 9:11 [PATCH v2 0/3] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-02-22 9:11 ` [PATCH v2 1/3] mm/sparse: Add a static variable nr_present_sections Baoquan He
2018-02-22 21:24 ` Andrew Morton
2018-02-22 23:56 ` Baoquan He [this message]
2018-02-22 9:11 ` [PATCH v2 2/3] mm/sparsemem: Defer the ms->section_mem_map clearing Baoquan He
2018-02-22 9:11 ` [PATCH v2 3/3] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-02-22 10:07 ` Pankaj Gupta
2018-02-22 10:39 ` Baoquan He
2018-02-22 22:22 ` Dave Hansen
2018-02-23 2:38 ` Baoquan He
2018-02-22 9:15 ` [PATCH v2 0/3] " Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222235639.GD693@localhost.localdomain \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).