From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f70.google.com (mail-oi0-f70.google.com [209.85.218.70]) by kanga.kvack.org (Postfix) with ESMTP id 408606B0007 for ; Tue, 27 Feb 2018 14:59:19 -0500 (EST) Received: by mail-oi0-f70.google.com with SMTP id p6so19755oic.9 for ; Tue, 27 Feb 2018 11:59:19 -0800 (PST) Received: from foss.arm.com (foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id w197si3511701oie.66.2018.02.27.11.59.18 for ; Tue, 27 Feb 2018 11:59:18 -0800 (PST) Date: Tue, 27 Feb 2018 19:59:19 +0000 From: Will Deacon Subject: Re: =?utf-8?B?562U5aSNOiBbUkZDIHBhdGNoXSBp?= =?utf-8?Q?oremap?= =?utf-8?Q?=3A?= don't set up huge I/O mappings when p4d/pud/pmd is zero Message-ID: <20180227195919.GA5348@arm.com> References: <1514460261-65222-1-git-send-email-guohanjun@huawei.com> <861128ce-966f-7006-45ba-6a7298918686@codeaurora.org> <1519175992.16384.121.camel@hpe.com> <20180221115758.GA7614@arm.com> <32c9b1c3-086b-ba54-f9e9-aefa50066730@huawei.com> <20180226110422.GD8736@arm.com> <1519763686.2693.2.camel@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1519763686.2693.2.camel@hpe.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Kani, Toshi" Cc: "guohanjun@huawei.com" , "linux-kernel@vger.kernel.org" , "linuxarm@huawei.com" , "linux-mm@kvack.org" , "wxf.wang@hisilicon.com" , "akpm@linux-foundation.org" , "mark.rutland@arm.com" , "catalin.marinas@arm.com" , "linux-arm-kernel@lists.infradead.org" , "cpandya@codeaurora.org" , "Hocko, Michal" , "hanjun.guo@linaro.org" On Tue, Feb 27, 2018 at 07:49:42PM +0000, Kani, Toshi wrote: > On Mon, 2018-02-26 at 20:53 +0800, Hanjun Guo wrote: > > On 2018/2/26 19:04, Will Deacon wrote: > > > On Mon, Feb 26, 2018 at 06:57:20PM +0800, Hanjun Guo wrote: > > > > Simply do something below at now (before the broken code is fixed)? > > > > > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > > > index b2b95f7..a86148c 100644 > > > > --- a/arch/arm64/Kconfig > > > > +++ b/arch/arm64/Kconfig > > > > @@ -84,7 +84,6 @@ config ARM64 > > > > select HAVE_ALIGNED_STRUCT_PAGE if SLUB > > > > select HAVE_ARCH_AUDITSYSCALL > > > > select HAVE_ARCH_BITREVERSE > > > > - select HAVE_ARCH_HUGE_VMAP > > > > select HAVE_ARCH_JUMP_LABEL > > > > select HAVE_ARCH_KASAN if !(ARM64_16K_PAGES && ARM64_VA_BITS_48) > > > > select HAVE_ARCH_KGDB > > > > > > No, that actually breaks with the use of block mappings for the kernel > > > text. Anyway, see: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=15122ee2c515a253b0c66a3e618bc7ebe35105eb > > > > Sorry, just back from holidays and didn't catch up with all the emails, > > thanks for taking care of this. > > I will work on a fix for the common/x86 code. Ace, thanks. I'm more than happy to review any changes you make to the core code from a break-before-make perspective. Just stick me on cc. Cheers, Will -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org