From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, Matthew Wilcox <mawilcox@microsoft.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] Split page_type out from mapcount
Date: Thu, 1 Mar 2018 08:17:50 +0100 [thread overview]
Message-ID: <20180301081750.42b135c3@mschwideX1> (raw)
In-Reply-To: <20180228223157.9281-1-willy@infradead.org>
On Wed, 28 Feb 2018 14:31:53 -0800
Matthew Wilcox <willy@infradead.org> wrote:
> From: Matthew Wilcox <mawilcox@microsoft.com>
>
> I want to use the _mapcount field to record what a page is in use as.
> This can help with debugging and we can also expose that information to
> userspace through /proc/kpageflags to help diagnose memory usage (not
> included as part of this patch set).
>
> First, we need s390 to stop using _mapcount for its own purposes;
> Martin, I hope you have time to look at this patch. I must confess I
> don't quite understand what the different bits are used for in the upper
> nybble of the _mapcount, but I tried to replicate what you were doing
> faithfully.
Yeah, that is a nasty bit of code. On s390 we have 2K page tables (pte)
but 4K pages. If we use full pages for the pte tables we waste 2K of
memory for each of the tables. So we allocate 4K and split it into two
2K pieces. Now we have to keep track of the pieces to be able to free
them again.
I try to give your patch a spin today. It should be stand-alone, no ?
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-03-01 7:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 22:31 [PATCH v3 0/4] Split page_type out from mapcount Matthew Wilcox
2018-02-28 22:31 ` [PATCH v3 1/4] s390: Use _refcount for pgtables Matthew Wilcox
2018-03-01 12:53 ` Kirill A. Shutemov
2018-03-01 14:04 ` Martin Schwidefsky
2018-03-01 14:28 ` Kirill A. Shutemov
2018-03-01 14:39 ` Martin Schwidefsky
2018-02-28 22:31 ` [PATCH v3 2/4] mm: Split page_type out from _map_count Matthew Wilcox
2018-02-28 22:31 ` [PATCH v3 3/4] mm: Mark pages allocated through vmalloc Matthew Wilcox
2018-02-28 22:31 ` [PATCH v3 4/4] mm: Mark pages in use for page tables Matthew Wilcox
2018-02-28 23:22 ` [PATCH v3 0/4] Split page_type out from mapcount Randy Dunlap
2018-03-01 1:31 ` Matthew Wilcox
2018-03-01 7:17 ` Martin Schwidefsky [this message]
2018-03-01 8:00 ` Martin Schwidefsky
2018-03-01 12:44 ` Kirill A. Shutemov
2018-03-01 14:47 ` Martin Schwidefsky
2018-03-01 14:50 ` Matthew Wilcox
2018-03-01 15:02 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301081750.42b135c3@mschwideX1 \
--to=schwidefsky@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).