From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id 492AC6B0005 for ; Thu, 8 Mar 2018 18:48:02 -0500 (EST) Received: by mail-pf0-f200.google.com with SMTP id h11so641060pfn.0 for ; Thu, 08 Mar 2018 15:48:02 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id g7-v6si7893247plp.38.2018.03.08.15.48.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Mar 2018 15:48:01 -0800 (PST) Date: Thu, 8 Mar 2018 15:48:00 -0800 From: Matthew Wilcox Subject: Re: [PATCH] mm: Change return type to vm_fault_t Message-ID: <20180308234800.GF29073@bombadil.infradead.org> References: <20180308130523.GA30642@jordon-HP-15-Notebook-PC> <20180308222201.GB29073@bombadil.infradead.org> <20180308152244.2ba75bc2a766541ab8330eb0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180308152244.2ba75bc2a766541ab8330eb0@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Souptick Joarder , linux-mm@kvack.org On Thu, Mar 08, 2018 at 03:22:44PM -0800, Andrew Morton wrote: > On Thu, 8 Mar 2018 14:22:01 -0800 Matthew Wilcox wrote: > > On Thu, Mar 08, 2018 at 06:35:23PM +0530, Souptick Joarder wrote: > > > Use new return type vm_fault_t for fault handler > > > in struct vm_operations_struct. > > > > > > vmf_insert_mixed(), vmf_insert_pfn() and vmf_insert_page() > > > are newly added inline wrapper functions. > > > > > > Signed-off-by: Souptick Joarder > > > > Reviewed-by: Matthew Wilcox > > > > Andrew, the plan for these patches is to introduce the typedef, initially > > just as documentation ("This function should return a VM_FAULT_ status"). > > We'll trickle the patches to individual drivers/filesystems in through > > the maintainers, as far as possible. In a few months, we'll probably > > dump a pile of patches to unloved drivers on you for merging. Then we'll > > change the typedef to an unsigned int and break the compilation of any > > unconverted driver. > > > > Souptick has done a few dozen drivers already, and I've been doing my best > > to keep up with reviewing the patches submitted. There's some interesting > > patterns and commonalities between drivers (not to mention a few outright > > bugs) that we've noticed, and this'll be a good time to clean them up. > > OK. All of this should be in the changelog, please. Along with a full > explanation of the reasons for adding the new functions. Agreed. Souptick, can you take care of doing that and resubmitting the patch? > > It'd be great to get this into Linus' tree sooner so we can start > > submitting the patches to the driver maintainers. > > Sure. I assume that vm_fault_t is `int', so this bare patch won't > cause a ton of type mismatch warnings? Exactly so.