From: jglisse@redhat.com
To: linux-mm@kvack.org
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"Jérôme Glisse" <jglisse@redhat.com>,
stable@vger.kernel.org, "Evgeny Baskakov" <ebaskakov@nvidia.com>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Mark Hairgrove" <mhairgrove@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>
Subject: [PATCH 04/14] mm/hmm: hmm_pfns_bad() was accessing wrong struct
Date: Fri, 16 Mar 2018 15:14:09 -0400 [thread overview]
Message-ID: <20180316191414.3223-5-jglisse@redhat.com> (raw)
In-Reply-To: <20180316191414.3223-1-jglisse@redhat.com>
From: JA(C)rA'me Glisse <jglisse@redhat.com>
The private field of mm_walk struct point to an hmm_vma_walk struct and
not to the hmm_range struct desired. Fix to get proper struct pointer.
Signed-off-by: JA(C)rA'me Glisse <jglisse@redhat.com>
Cc: stable@vger.kernel.org
Cc: Evgeny Baskakov <ebaskakov@nvidia.com>
Cc: Ralph Campbell <rcampbell@nvidia.com>
Cc: Mark Hairgrove <mhairgrove@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>
---
mm/hmm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/hmm.c b/mm/hmm.c
index 6088fa6ed137..64d9e7dae712 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -293,7 +293,8 @@ static int hmm_pfns_bad(unsigned long addr,
unsigned long end,
struct mm_walk *walk)
{
- struct hmm_range *range = walk->private;
+ struct hmm_vma_walk *hmm_vma_walk = walk->private;
+ struct hmm_range *range = hmm_vma_walk->range;
hmm_pfn_t *pfns = range->pfns;
unsigned long i;
--
2.14.3
next prev parent reply other threads:[~2018-03-16 19:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 19:14 [PATCH 0/4] hmm: fixes and documentations v2 jglisse
2018-03-16 19:14 ` [PATCH 01/14] mm/hmm: documentation editorial update to HMM documentation jglisse
2018-03-16 19:14 ` [PATCH 02/14] mm/hmm: fix header file if/else/endif maze jglisse
2018-03-16 21:09 ` Andrew Morton
2018-03-16 21:18 ` Jerome Glisse
2018-03-16 21:35 ` Andrew Morton
2018-03-16 21:40 ` John Hubbard
2018-03-17 1:20 ` [PATCH 02/14] mm/hmm: fix header file if/else/endif maze v2 jglisse
2018-03-16 19:14 ` [PATCH 03/14] mm/hmm: HMM should have a callback before MM is destroyed v2 jglisse
2018-03-16 21:12 ` Andrew Morton
2018-03-16 21:26 ` Jerome Glisse
2018-03-16 21:37 ` John Hubbard
2018-03-17 2:36 ` John Hubbard
2018-03-17 3:47 ` John Hubbard
2018-03-17 4:39 ` John Hubbard
2018-03-16 19:14 ` jglisse [this message]
2018-03-17 2:04 ` [PATCH 04/14] mm/hmm: hmm_pfns_bad() was accessing wrong struct John Hubbard
2018-03-16 19:14 ` [PATCH 05/14] mm/hmm: use struct for hmm_vma_fault(), hmm_vma_get_pfns() parameters jglisse
2018-03-17 3:08 ` John Hubbard
2018-03-16 19:14 ` [PATCH 06/14] mm/hmm: remove HMM_PFN_READ flag and ignore peculiar architecture jglisse
2018-03-17 3:30 ` John Hubbard
2018-03-16 19:14 ` [PATCH 07/14] mm/hmm: use uint64_t for HMM pfn instead of defining hmm_pfn_t to ulong jglisse
2018-03-17 3:59 ` John Hubbard
2018-03-16 19:14 ` [PATCH 08/14] mm/hmm: cleanup special vma handling (VM_SPECIAL) jglisse
2018-03-17 4:35 ` John Hubbard
2018-03-16 19:14 ` [PATCH 09/14] mm/hmm: do not differentiate between empty entry or missing directory jglisse
2018-03-19 23:06 ` John Hubbard
2018-03-20 2:08 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316191414.3223-5-jglisse@redhat.com \
--to=jglisse@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebaskakov@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhairgrove@nvidia.com \
--cc=rcampbell@nvidia.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).