From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Michal Hocko <mhocko@suse.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
akpm@linux-foundation.org, linux-mm@kvack.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v2] mm: Warn on lock_page() from reclaim context.
Date: Mon, 19 Mar 2018 13:14:40 +0300 [thread overview]
Message-ID: <20180319101440.6xe5ixd5nn4zrvl2@node.shutemov.name> (raw)
In-Reply-To: <20180319090419.GR23100@dhcp22.suse.cz>
On Mon, Mar 19, 2018 at 10:04:19AM +0100, Michal Hocko wrote:
> On Sun 18-03-18 10:22:49, Tetsuo Handa wrote:
> > >From f43b8ca61b76f9a19c13f6bf42b27fad9554afc0 Mon Sep 17 00:00:00 2001
> > From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > Date: Sun, 18 Mar 2018 10:18:01 +0900
> > Subject: [PATCH v2] mm: Warn on lock_page() from reclaim context.
> >
> > Kirill A. Shutemov noticed that calling lock_page[_killable]() from
> > reclaim context might cause deadlock. In order to help finding such
> > lock_page[_killable]() users (including out of tree users), this patch
> > emits warning messages when CONFIG_PROVE_LOCKING is enabled.
>
> So how do you ensure that this won't cause false possitives? E.g. do we
> ever allocate while holding the page lock and not having the page on the
> LRU list?
Hm. Do we even have a reason to lock such pages?
Probably we do, but I cannot come up with an example.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-03-19 10:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 14:11 [PATCH] mm: Warn on lock_page() from reclaim context Tetsuo Handa
2018-03-17 15:54 ` Kirill A. Shutemov
2018-03-18 1:22 ` [PATCH v2] " Tetsuo Handa
2018-03-18 8:55 ` Kirill A. Shutemov
2018-03-19 9:04 ` Michal Hocko
2018-03-19 10:14 ` Kirill A. Shutemov [this message]
2018-03-19 10:33 ` Michal Hocko
2018-03-19 10:45 ` Kirill A. Shutemov
2018-03-19 10:55 ` Michal Hocko
2018-03-19 12:04 ` Tetsuo Handa
2018-03-19 22:08 ` Andrew Morton
2018-03-20 8:44 ` Michal Hocko
2018-03-20 17:50 ` Andrew Morton
2018-03-29 7:04 ` [lkp-robot] [mm] 67ffc906f8: WARNING:at_mm/filemap.c:#__warn_lock_page_from_reclaim_context kernel test robot
2018-03-29 10:32 ` [lkp-robot] [mm] 67ffc906f8:WARNING:at_mm/filemap.c:#__warn_lock_page_from_reclaim_context Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319101440.6xe5ixd5nn4zrvl2@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).