From: Matthew Wilcox <willy@infradead.org>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: adobriyan@gmail.com, mhocko@kernel.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct
Date: Fri, 23 Mar 2018 21:30:44 -0700 [thread overview]
Message-ID: <20180324043044.GA22733@bombadil.infradead.org> (raw)
In-Reply-To: <1521851771-108673-1-git-send-email-yang.shi@linux.alibaba.com>
> So, introduce a new rwlock in mm_struct to protect the concurrent access
> to arg_start|end and env_start|end.
I don't think an rwlock makes much sense here. There is almost no
concurrency on the read side, and an rwlock is more expensive than
a spinlock. Just use a spinlock.
next prev parent reply other threads:[~2018-03-24 4:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 0:36 [PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct Yang Shi
2018-03-24 4:30 ` Matthew Wilcox [this message]
2018-03-25 0:32 ` Yang Shi
2018-03-26 14:49 ` Tetsuo Handa
2018-03-26 14:55 ` Michal Hocko
2018-03-26 15:31 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180324043044.GA22733@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).