linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Huang Ying <ying.huang@intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Kemi Wang <kemi.wang@intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>, Michal Hocko <mhocko@suse.com>,
	Mel Gorman <mgorman@techsingularity.net>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v4 2/3] mm/free_pcppages_bulk: do not hold lock when picking pages to free
Date: Mon, 26 Mar 2018 11:03:45 +0800	[thread overview]
Message-ID: <20180326030344.GA30075@intel.com> (raw)
In-Reply-To: <20180322151719.GA28468@bombadil.infradead.org>

On Thu, Mar 22, 2018 at 08:17:19AM -0700, Matthew Wilcox wrote:
> On Tue, Mar 13, 2018 at 11:34:53AM +0800, Aaron Lu wrote:
> > I wish there is a data structure that has the flexibility of list while
> > at the same time we can locate the Nth element in the list without the
> > need to iterate. That's what I'm looking for when developing clustered
> > allocation for order 0 pages. In the end, I had to use another place to
> > record where the Nth element is. I hope to send out v2 of that RFC
> > series soon but I'm still collecting data for it. I would appreciate if
> > people could take a look then :-)
> 
> Sorry, I missed this.  There is such a data structure -- the IDR, or
> possibly a bare radix tree, or we can build a better data structure on
> top of the radix tree (I talked about one called the XQueue a while ago).
> 
> The IDR will automatically grow to whatever needed size, it stores
> pointers, you can find out quickly where the last allocated index is,
> you can remove from the middle of the array.  Disadvantage is that it
> requires memory allocation to store the array of pointers, *but* it
> can always hold at least one entry.  So if you have no memory, you can
> always return the one element in your IDR to the free pool and allocate
> from that page.

Thanks for the pointer, will take a look later.
Currently I'm focusing on finding real workloads that have zone lock
contention issue.

  reply	other threads:[~2018-03-26  3:02 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01  6:28 [PATCH v4 0/3] mm: improve zone->lock scalability Aaron Lu
2018-03-01  6:28 ` [PATCH v4 1/3] mm/free_pcppages_bulk: update pcp->count inside Aaron Lu
2018-03-01 12:11   ` David Rientjes
2018-03-01 13:45   ` Michal Hocko
2018-03-12 13:22   ` Vlastimil Babka
2018-03-13  2:11     ` Aaron Lu
2018-03-01  6:28 ` [PATCH v4 2/3] mm/free_pcppages_bulk: do not hold lock when picking pages to free Aaron Lu
2018-03-01 13:55   ` Michal Hocko
2018-03-02  7:15     ` Aaron Lu
2018-03-02 15:34       ` Dave Hansen
2018-03-02  7:31     ` Huang, Ying
2018-03-02  0:01   ` Andrew Morton
2018-03-02  8:01     ` Aaron Lu
2018-03-02 21:23       ` Andrew Morton
2018-03-02 21:25         ` Dave Hansen
2018-03-12 14:22   ` Vlastimil Babka
2018-03-13  3:34     ` Aaron Lu
2018-03-22 15:17       ` Matthew Wilcox
2018-03-26  3:03         ` Aaron Lu [this message]
2018-03-01  6:28 ` [PATCH v4 3/3] mm/free_pcppages_bulk: prefetch buddy while not holding lock Aaron Lu
2018-03-01 14:00   ` Michal Hocko
2018-03-02  8:31     ` Aaron Lu
2018-03-02 17:55     ` Vlastimil Babka
2018-03-02 18:00       ` Dave Hansen
2018-03-02 18:08         ` Vlastimil Babka
2018-03-05 11:41       ` Aaron Lu
2018-03-05 11:48         ` Aaron Lu
2018-03-06  7:55         ` Vlastimil Babka
2018-03-06 12:27           ` Aaron Lu
2018-03-06 12:53             ` Matthew Wilcox
2018-03-02  0:09   ` Andrew Morton
2018-03-02  8:27     ` Aaron Lu
2018-03-09  8:24       ` [PATCH v4 3/3 update] " Aaron Lu
2018-03-09 21:58         ` Andrew Morton
2018-03-10 14:46           ` Aaron Lu
2018-03-12 15:05           ` Vlastimil Babka
2018-03-12 17:32         ` Dave Hansen
2018-03-13  3:35           ` Aaron Lu
2018-03-13  7:04             ` Aaron Lu
2018-03-20  9:50               ` Vlastimil Babka
2018-03-20 11:31                 ` [PATCH v4 3/3 update2] " Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180326030344.GA30075@intel.com \
    --to=aaron.lu@intel.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=kemi.wang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=rientjes@google.com \
    --cc=tim.c.chen@linux.intel.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).