From: Michal Hocko <mhocko@kernel.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Yang Shi <yang.shi@linux.alibaba.com>,
adobriyan@gmail.com, willy@infradead.org, mguzik@redhat.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct
Date: Wed, 28 Mar 2018 15:10:42 +0200 [thread overview]
Message-ID: <20180328131042.GL9275@dhcp22.suse.cz> (raw)
In-Reply-To: <20180327185217.GK2236@uranus>
On Tue 27-03-18 21:52:17, Cyrill Gorcunov wrote:
> On Tue, Mar 27, 2018 at 02:38:11PM -0400, Yang Shi wrote:
> > > Why do we need to hold mmap_sem here and call find_vma, when only
> > > PR_SET_MM_ENV_END: is consuming it? I guess we can replace it wit the
> > > new lock and take the mmap_sem only for PR_SET_MM_ENV_END.
> >
> > Actually, I didn't think of why. It looks prctl_set_mm() checks if vma does
> > exist when it tries to set stack_start, argv_* and env_*, btw not only
> > env_end.
> >
> > Cyrill may be able to give us some hint since C/R is the main user of this
> > API.
>
> First and most important it makes code smaller. This prctl call is really
> rarely used. Of course we can optimize it, but as I said I would prefer
> to simply deprecate this old interface (and I gonne to do so once time
> permit).
Ohh, it would be really great if we can remove this thingy altogether. I
cannot say it has a wee bit of my sympathy.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-03-28 13:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 18:20 [v2 PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct Yang Shi
2018-03-26 18:37 ` Matthew Wilcox
2018-03-26 19:21 ` Cyrill Gorcunov
2018-03-26 21:10 ` Tetsuo Handa
2018-03-26 21:20 ` Yang Shi
2018-03-26 21:29 ` Cyrill Gorcunov
2018-03-26 22:00 ` Tetsuo Handa
2018-03-26 22:12 ` Yang Shi
2018-03-27 7:38 ` Cyrill Gorcunov
2018-03-27 7:37 ` Cyrill Gorcunov
2018-03-26 21:59 ` Yang Shi
2018-03-27 7:32 ` Cyrill Gorcunov
2018-03-27 18:44 ` Yang Shi
2018-03-26 19:42 ` Mateusz Guzik
2018-03-26 21:10 ` Yang Shi
2018-03-27 6:29 ` Michal Hocko
2018-03-27 14:31 ` Mateusz Guzik
2018-03-27 14:43 ` Michal Hocko
2018-03-27 18:38 ` Yang Shi
2018-03-27 18:52 ` Cyrill Gorcunov
2018-03-28 13:10 ` Michal Hocko [this message]
2018-04-02 1:58 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328131042.GL9275@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mguzik@redhat.com \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).