From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f69.google.com (mail-pl0-f69.google.com [209.85.160.69]) by kanga.kvack.org (Postfix) with ESMTP id 844AB6B0003 for ; Wed, 4 Apr 2018 18:37:06 -0400 (EDT) Received: by mail-pl0-f69.google.com with SMTP id c2-v6so12674150plo.21 for ; Wed, 04 Apr 2018 15:37:06 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id g1-v6si4107843plt.520.2018.04.04.15.37.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Apr 2018 15:37:05 -0700 (PDT) Date: Wed, 4 Apr 2018 15:37:03 -0700 From: Andrew Morton Subject: Re: [PATCH v1] mm: help the ALLOC_HARDER allocation pass the watermarki when CMA on Message-Id: <20180404153703.8f9f04df4c991554f3bf0434@linux-foundation.org> In-Reply-To: <20180404003028.GA6628@js1304-desktop> References: <1521791852-7048-1-git-send-email-zhaoyang.huang@spreadtrum.com> <20180323083847.GJ23100@dhcp22.suse.cz> <20180323093327.GM23100@dhcp22.suse.cz> <20180323130408.0c6451fac02c49b535ec7485@linux-foundation.org> <20180404003028.GA6628@js1304-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Michal Hocko , Zhaoyang Huang , zhaoyang.huang@spreadtrum.com, Vlastimil Babka , Mel Gorman , Johannes Weiner , vel Tatashin , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-patch-test@lists.linaro.org On Wed, 4 Apr 2018 09:31:10 +0900 Joonsoo Kim wrote: > On Fri, Mar 23, 2018 at 01:04:08PM -0700, Andrew Morton wrote: > > On Fri, 23 Mar 2018 10:33:27 +0100 Michal Hocko wrote: > > > > > On Fri 23-03-18 17:19:26, Zhaoyang Huang wrote: > > > > On Fri, Mar 23, 2018 at 4:38 PM, Michal Hocko wrote: > > > > > On Fri 23-03-18 15:57:32, Zhaoyang Huang wrote: > > > > >> For the type of 'ALLOC_HARDER' page allocation, there is an express > > > > >> highway for the whole process which lead the allocation reach __rmqueue_xxx > > > > >> easier than other type. > > > > >> However, when CMA is enabled, the free_page within zone_watermark_ok() will > > > > >> be deducted for number the pages in CMA type, which may cause the watermark > > > > >> check fail, but there are possible enough HighAtomic or Unmovable and > > > > >> Reclaimable pages in the zone. So add 'alloc_harder' here to > > > > >> count CMA pages in to clean the obstacles on the way to the final. > > > > > > > > > > This is no longer the case in the current mmotm tree. Have a look at > > > > > Joonsoo's zone movable based CMA patchset http://lkml.kernel.org/r/1512114786-5085-1-git-send-email-iamjoonsoo.kim@lge.com > > > > > > > > > Thanks for the information. However, I can't find the commit in the > > > > latest mainline, is it merged? > > > > > > Not yet. It is still sitting in the mmomt tree. I am not sure what is > > > the merge plan but I guess it is still waiting for some review feedback. > > > > http://lkml.kernel.org/r/20171222001113.GA1729@js1304-P5Q-DELUXE > > > > That patchset has been floating about since December and still has > > unresolved issues. > > > > Joonsoo, can you please let us know the status? > > Hello, Andrew. > Sorry for a late response. > > Today, I finally have answered the question from Michal and it seems > that there is no problem at all. > > http://lkml.kernel.org/r/CAAmzW4NGv7RyCYyokPoj4aR3ySKub4jaBZ3k=pt_YReFbByvsw@mail.gmail.com > > You can merge the patch as is. > hm. There was also a performance regression reported: http://lkml.kernel.org/r/20180102063528.GG30397@yexl-desktop