From: Andrew Morton <akpm@linux-foundation.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: willy@infradead.org, linux-mm@kvack.org
Subject: Re: [PATCH] include: mm: Adding new inline function vmf_error
Date: Thu, 5 Apr 2018 12:53:22 -0700 [thread overview]
Message-ID: <20180405125322.2ef3abfc6159a72725095bd0@linux-foundation.org> (raw)
In-Reply-To: <20180405162225.GA23411@jordon-HP-15-Notebook-PC>
On Thu, 5 Apr 2018 21:52:25 +0530 Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Many places in drivers/ file systems error was handled
> like below -
> ret = (ret == -ENOMEM) ? VM_FAULT_OOM : VM_FAULT_SIGBUS;
>
> This new inline function vmf_error() will replace this
> and return vm_fault_t type err.
>
> ...
>
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2453,6 +2453,18 @@ static inline vm_fault_t vmf_insert_pfn(struct vm_area_struct *vma,
> return VM_FAULT_NOPAGE;
> }
>
> +static inline vm_fault_t vmf_error(int err)
> +{
> + vm_fault_t ret;
> +
> + if (err == -ENOMEM)
> + ret = VM_FAULT_OOM;
> + else
> + ret = VM_FAULT_SIGBUS;
> +
> + return ret;
> +}
> +
That's a bit verbose. Why not simply
return (err == -ENOMEM) ? VM_FAULT_OOM : VM_FAULT_SIGBUS;
Also, if would be nice to see some sites converted so we can see the
benefit of the patch and to actually test it.
next prev parent reply other threads:[~2018-04-05 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 16:22 [PATCH] include: mm: Adding new inline function vmf_error Souptick Joarder
2018-04-05 16:52 ` Matthew Wilcox
2018-04-05 19:53 ` Andrew Morton [this message]
2018-04-05 20:26 ` Matthew Wilcox
2018-05-02 6:17 ` Souptick Joarder
2018-05-02 21:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405125322.2ef3abfc6159a72725095bd0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).