From: Paul McQuade <paulmcquad@gmail.com>
To: paulmcquad@gmail.com
Cc: konrad.wilk@oracle.com, labbott@redhat.com,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
guptap@codeaurora.org, vbabka@suse.cz,
mgorman@techsingularity.net, hannes@cmpxchg.org,
rientjes@google.com, mhocko@suse.com, rppt@linux.vnet.ibm.com,
dave@stgolabs.net, hmclauchlan@fb.com, tglx@linutronix.de,
pombredanne@nexb.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 2/3] mm: Replace S_IWUSR with 0200
Date: Sat, 7 Apr 2018 19:47:25 +0100 [thread overview]
Message-ID: <20180407184726.8634-2-paulmcquad@gmail.com> (raw)
In-Reply-To: <20180407184726.8634-1-paulmcquad@gmail.com>
Fix checkpatch warnings about S_IWUSR being less readable than
providing the permissions octal as '0200'.
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
mm/cma_debug.c | 4 ++--
mm/compaction.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/cma_debug.c b/mm/cma_debug.c
index 6494c7a7d257..f0af3f93d1e4 100644
--- a/mm/cma_debug.c
+++ b/mm/cma_debug.c
@@ -172,10 +172,10 @@ static void cma_debugfs_add_one(struct cma *cma, int idx)
tmp = debugfs_create_dir(name, cma_debugfs_root);
- debugfs_create_file("alloc", S_IWUSR, tmp, cma,
+ debugfs_create_file("alloc", 0200, tmp, cma,
&cma_alloc_fops);
- debugfs_create_file("free", S_IWUSR, tmp, cma,
+ debugfs_create_file("free", 0200, tmp, cma,
&cma_free_fops);
debugfs_create_file("base_pfn", 0444, tmp,
diff --git a/mm/compaction.c b/mm/compaction.c
index 88d01a50a015..50d0000a6afd 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1900,7 +1900,7 @@ static ssize_t sysfs_compact_node(struct device *dev,
return count;
}
-static DEVICE_ATTR(compact, S_IWUSR, NULL, sysfs_compact_node);
+static DEVICE_ATTR(compact, 0200, NULL, sysfs_compact_node);
int compaction_register_node(struct node *node)
{
--
2.16.2
next prev parent reply other threads:[~2018-04-07 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 18:47 [PATCH 1/3] mm: replace S_IRUGO with 0444 Paul McQuade
2018-04-07 18:47 ` Paul McQuade [this message]
2018-04-07 18:47 ` [PATCH 3/3] mm: replace S_IRUSR | S_IWUSR with 0600 Paul McQuade
2018-04-07 20:11 ` [PATCH 1/3] mm: replace S_IRUGO with 0444 Joe Perches
2018-04-07 20:37 ` Paul Mc Quade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180407184726.8634-2-paulmcquad@gmail.com \
--to=paulmcquad@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=gregkh@linuxfoundation.org \
--cc=guptap@codeaurora.org \
--cc=hannes@cmpxchg.org \
--cc=hmclauchlan@fb.com \
--cc=konrad.wilk@oracle.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=pombredanne@nexb.com \
--cc=rientjes@google.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).