linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: Bart.VanAssche@wdc.com, willy@infradead.org,
	linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 5/7] block: use GFP_NOIO instead of __GFP_DIRECT_RECLAIM
Date: Mon,  9 Apr 2018 17:39:14 +0200	[thread overview]
Message-ID: <20180409153916.23901-6-hch@lst.de> (raw)
In-Reply-To: <20180409153916.23901-1-hch@lst.de>

We just can't do I/O when doing block layer requests allocations,
so use GFP_NOIO instead of the even more limited __GFP_DIRECT_RECLAIM.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 16ff472233ba..432923751551 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1578,8 +1578,7 @@ static struct request *blk_old_get_request(struct request_queue *q,
 				unsigned int op, blk_mq_req_flags_t flags)
 {
 	struct request *rq;
-	gfp_t gfp_mask = flags & BLK_MQ_REQ_NOWAIT ? GFP_ATOMIC :
-			 __GFP_DIRECT_RECLAIM;
+	gfp_t gfp_mask = flags & BLK_MQ_REQ_NOWAIT ? GFP_ATOMIC : GFP_NOIO;
 	int ret = 0;
 
 	WARN_ON_ONCE(q->mq_ops);
@@ -2057,7 +2056,7 @@ static blk_qc_t blk_queue_bio(struct request_queue *q, struct bio *bio)
 	 * Returns with the queue unlocked.
 	 */
 	blk_queue_enter_live(q);
-	req = get_request(q, bio->bi_opf, bio, 0, __GFP_DIRECT_RECLAIM);
+	req = get_request(q, bio->bi_opf, bio, 0, GFP_NOIO);
 	if (IS_ERR(req)) {
 		blk_queue_exit(q);
 		__wbt_done(q->rq_wb, wb_acct);
-- 
2.16.3

  parent reply	other threads:[~2018-04-09 15:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 15:39 [RFC] fix confusion around GFP_* flags and blk_get_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 1/7] scsi/osd: remove the gfp argument to osd_start_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 2/7] block: fix __get_request documentation Christoph Hellwig
2018-04-09 15:39 ` [PATCH 3/7] block: sanitize blk_get_request calling conventions Christoph Hellwig
2018-04-10  6:26   ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 4/7] block: pass explicit gfp_t to get_request Christoph Hellwig
2018-04-10  6:27   ` Hannes Reinecke
2018-04-09 15:39 ` Christoph Hellwig [this message]
2018-04-10  6:27   ` [PATCH 5/7] block: use GFP_NOIO instead of __GFP_DIRECT_RECLAIM Hannes Reinecke
2018-04-09 15:39 ` [PATCH 6/7] block: consistently use GFP_NOIO instead of __GFP_NORECLAIM Christoph Hellwig
2018-04-09 16:03   ` Matthew Wilcox
2018-04-09 17:20     ` Christoph Hellwig
2018-04-10  6:28   ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request Christoph Hellwig
2018-04-09 16:52   ` Matthew Wilcox
2018-04-09 17:21     ` Christoph Hellwig
2018-04-10  6:29   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180409153916.23901-6-hch@lst.de \
    --to=hch@lst.de \
    --cc=Bart.VanAssche@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).