From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, Bart.VanAssche@wdc.com,
linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 6/7] block: consistently use GFP_NOIO instead of __GFP_NORECLAIM
Date: Mon, 9 Apr 2018 19:20:54 +0200 [thread overview]
Message-ID: <20180409172054.GA5697@lst.de> (raw)
In-Reply-To: <20180409160354.GD11756@bombadil.infradead.org>
On Mon, Apr 09, 2018 at 09:03:54AM -0700, Matthew Wilcox wrote:
> > @@ -499,7 +499,7 @@ int sg_scsi_ioctl(struct request_queue *q, struct gendisk *disk, fmode_t mode,
> > break;
> > }
> >
> > - if (bytes && blk_rq_map_kern(q, rq, buffer, bytes, __GFP_RECLAIM)) {
> > + if (bytes && blk_rq_map_kern(q, rq, buffer, bytes, GFP_NOIO)) {
>
> We don't seem to have grabbed any locks between the line which allocates
> memory using GFP_USER (line 446) and here, so I don't see why we should
> prohibit I/O?
No change of behavior for this patch. If you care deeply about using
GFP_KERNEL here send an incremental patch that I can add to the end of
the series.
next prev parent reply other threads:[~2018-04-09 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 15:39 [RFC] fix confusion around GFP_* flags and blk_get_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 1/7] scsi/osd: remove the gfp argument to osd_start_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 2/7] block: fix __get_request documentation Christoph Hellwig
2018-04-09 15:39 ` [PATCH 3/7] block: sanitize blk_get_request calling conventions Christoph Hellwig
2018-04-10 6:26 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 4/7] block: pass explicit gfp_t to get_request Christoph Hellwig
2018-04-10 6:27 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 5/7] block: use GFP_NOIO instead of __GFP_DIRECT_RECLAIM Christoph Hellwig
2018-04-10 6:27 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 6/7] block: consistently use GFP_NOIO instead of __GFP_NORECLAIM Christoph Hellwig
2018-04-09 16:03 ` Matthew Wilcox
2018-04-09 17:20 ` Christoph Hellwig [this message]
2018-04-10 6:28 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request Christoph Hellwig
2018-04-09 16:52 ` Matthew Wilcox
2018-04-09 17:21 ` Christoph Hellwig
2018-04-10 6:29 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409172054.GA5697@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).