From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, Bart.VanAssche@wdc.com, willy@infradead.org,
linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/7] block: sanitize blk_get_request calling conventions
Date: Tue, 10 Apr 2018 08:26:08 +0200 [thread overview]
Message-ID: <20180410082608.2cb9a6be@pentland.suse.de> (raw)
In-Reply-To: <20180409153916.23901-4-hch@lst.de>
On Mon, 9 Apr 2018 17:39:12 +0200
Christoph Hellwig <hch@lst.de> wrote:
> Switch everyone to blk_get_request_flags, and then rename
> blk_get_request_flags to blk_get_request.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-core.c | 14 +++-----------
> block/bsg.c | 5 ++---
> block/scsi_ioctl.c | 8 +++-----
> drivers/block/paride/pd.c | 2 +-
> drivers/block/pktcdvd.c | 2 +-
> drivers/block/sx8.c | 2 +-
> drivers/block/virtio_blk.c | 2 +-
> drivers/cdrom/cdrom.c | 2 +-
> drivers/ide/ide-atapi.c | 2 +-
> drivers/ide/ide-cd.c | 2 +-
> drivers/ide/ide-cd_ioctl.c | 2 +-
> drivers/ide/ide-devsets.c | 2 +-
> drivers/ide/ide-disk.c | 2 +-
> drivers/ide/ide-ioctls.c | 4 ++--
> drivers/ide/ide-park.c | 4 ++--
> drivers/ide/ide-pm.c | 5 ++---
> drivers/ide/ide-tape.c | 2 +-
> drivers/ide/ide-taskfile.c | 2 +-
> drivers/md/dm-mpath.c | 3 ++-
> drivers/mmc/core/block.c | 12 +++++-------
> drivers/scsi/osd/osd_initiator.c | 2 +-
> drivers/scsi/osst.c | 2 +-
> drivers/scsi/scsi_error.c | 2 +-
> drivers/scsi/scsi_lib.c | 2 +-
> drivers/scsi/sg.c | 2 +-
> drivers/scsi/st.c | 2 +-
> drivers/target/target_core_pscsi.c | 3 +--
> fs/nfsd/blocklayout.c | 2 +-
> include/linux/blkdev.h | 5 +----
> 29 files changed, 42 insertions(+), 59 deletions(-)
>
Long overdue.
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
next prev parent reply other threads:[~2018-04-10 6:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 15:39 [RFC] fix confusion around GFP_* flags and blk_get_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 1/7] scsi/osd: remove the gfp argument to osd_start_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 2/7] block: fix __get_request documentation Christoph Hellwig
2018-04-09 15:39 ` [PATCH 3/7] block: sanitize blk_get_request calling conventions Christoph Hellwig
2018-04-10 6:26 ` Hannes Reinecke [this message]
2018-04-09 15:39 ` [PATCH 4/7] block: pass explicit gfp_t to get_request Christoph Hellwig
2018-04-10 6:27 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 5/7] block: use GFP_NOIO instead of __GFP_DIRECT_RECLAIM Christoph Hellwig
2018-04-10 6:27 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 6/7] block: consistently use GFP_NOIO instead of __GFP_NORECLAIM Christoph Hellwig
2018-04-09 16:03 ` Matthew Wilcox
2018-04-09 17:20 ` Christoph Hellwig
2018-04-10 6:28 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request Christoph Hellwig
2018-04-09 16:52 ` Matthew Wilcox
2018-04-09 17:21 ` Christoph Hellwig
2018-04-10 6:29 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410082608.2cb9a6be@pentland.suse.de \
--to=hare@suse.de \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).