From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id 3B1D26B000D for ; Tue, 10 Apr 2018 02:29:16 -0400 (EDT) Received: by mail-pf0-f199.google.com with SMTP id e14so6340760pfi.9 for ; Mon, 09 Apr 2018 23:29:16 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id m32-v6si1924269pld.174.2018.04.09.23.29.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 09 Apr 2018 23:29:15 -0700 (PDT) Date: Tue, 10 Apr 2018 08:29:13 +0200 From: Hannes Reinecke Subject: Re: [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request Message-ID: <20180410082913.475c8ca3@pentland.suse.de> In-Reply-To: <20180409153916.23901-8-hch@lst.de> References: <20180409153916.23901-1-hch@lst.de> <20180409153916.23901-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: axboe@kernel.dk, Bart.VanAssche@wdc.com, willy@infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org On Mon, 9 Apr 2018 17:39:16 +0200 Christoph Hellwig wrote: > blk_get_request is used for pass-through style I/O and thus doesn't > need GFP_NOIO. > > Signed-off-by: Christoph Hellwig > --- > block/blk-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-core.c b/block/blk-core.c > index 432923751551..253a869558f9 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -1578,7 +1578,7 @@ static struct request > *blk_old_get_request(struct request_queue *q, unsigned int op, > blk_mq_req_flags_t flags) { > struct request *rq; > - gfp_t gfp_mask = flags & BLK_MQ_REQ_NOWAIT ? GFP_ATOMIC : > GFP_NOIO; > + gfp_t gfp_mask = flags & BLK_MQ_REQ_NOWAIT ? GFP_ATOMIC : > GFP_KERNEL; int ret = 0; > > WARN_ON_ONCE(q->mq_ops); Reviewed-by: Hannes Reinecke Cheers, Hannes