From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id DEE3B6B0027 for ; Mon, 16 Apr 2018 12:53:05 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id f3-v6so10656119plf.1 for ; Mon, 16 Apr 2018 09:53:05 -0700 (PDT) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0115.outbound.protection.outlook.com. [104.47.40.115]) by mx.google.com with ESMTPS id t131si9946838pgc.664.2018.04.16.09.53.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 16 Apr 2018 09:53:04 -0700 (PDT) From: Sasha Levin Subject: Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes Date: Mon, 16 Apr 2018 16:53:00 +0000 Message-ID: <20180416165258.GH2341@sasha-vm> References: <20180415144248.GP2341@sasha-vm> <20180416093058.6edca0bb@gandalf.local.home> <20180416153031.GA5039@amd> <20180416155031.GX2341@sasha-vm> <20180416160608.GA7071@amd> <20180416161412.GZ2341@sasha-vm> <20180416122244.146aec48@gandalf.local.home> <20180416163107.GC2341@sasha-vm> <20180416124711.048f1858@gandalf.local.home> In-Reply-To: <20180416124711.048f1858@gandalf.local.home> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <350FC0434CF1254DBE9401FFE3F4C425@namprd21.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Steven Rostedt Cc: Pavel Machek , Linus Torvalds , Petr Mladek , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , Cong Wang , Dave Hansen , Johannes Weiner , Mel Gorman , Michal Hocko , Vlastimil Babka , Peter Zijlstra , Jan Kara , Mathieu Desnoyers , Tetsuo Handa , Byungchul Park , Tejun Heo On Mon, Apr 16, 2018 at 12:47:11PM -0400, Steven Rostedt wrote: >On Mon, 16 Apr 2018 16:31:09 +0000 >Sasha Levin wrote: > >> On Mon, Apr 16, 2018 at 12:22:44PM -0400, Steven Rostedt wrote: >> >On Mon, 16 Apr 2018 16:14:15 +0000 >> >Sasha Levin wrote: >> > >> >> Since the rate we're seeing now with AUTOSEL is similar to what we we= re >> >> seeing before AUTOSEL, what's the problem it's causing? >> > >> >Does that mean we just doubled the rate of regressions? That's the >> >problem. >> >> No, the rate stayed the same :) >> >> If before ~2% of stable commits were buggy, this is still the case with >> AUTOSEL. > >Sorry, I didn't mean "rate" I meant "number". If the rate stayed the >same, that means the number increased. Indeed, just like the number of regressions in mainline has increased over time. >> >> >> >> >> How do you know if a bug bothers someone? >> >> >> >> If a user is annoyed by a LED issue, is he expected to triage the bug= , >> >> report it on LKML and patiently wait for the appropriate patch to be >> >> backported? >> > >> >Yes. >> >> I'm honestly not sure how to respond. >> >> Let me ask my wife (who is happy using Linux as a regular desktop user) >> how comfortable she would be with triaging kernel bugs... > >That's really up to the distribution, not the main kernel stable. Does >she download and compile the kernels herself? Does she use LEDs? > >The point is, stable is to keep what was working continued working. >If we don't care about introducing a regression, and just want to keep >regressions the same as mainline, why not just go to mainline? That way >you can also get the new features? Mainline already has the mantra to >not break user space. When I work on new features, I sometimes stumble >on bugs with the current features. And some of those fixes require a >rewrite. It was "good enough" before, but every so often could cause a >bug that the new feature would trigger more often. Do we back port that >rewrite? Do we backport fixes to old code that are more likely to be >triggered by new features? > >Ideally, we should be working on getting to no regressions to stable. This is exactly what we're doing. If a fix for a bug in -stable introduces a different regression, should we take it or not?=