linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sasha Levin <Alexander.Levin@microsoft.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Petr Mladek <pmladek@suse.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Peter Zijlstra <peterz@infradead.org>, Jan Kara <jack@suse.cz>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Byungchul Park <byungchul.park@lge.com>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes
Date: Tue, 17 Apr 2018 12:46:37 +0200	[thread overview]
Message-ID: <20180417104637.GD8445@kroah.com> (raw)
In-Reply-To: <20180416170010.GA11034@amd>

On Mon, Apr 16, 2018 at 07:00:10PM +0200, Pavel Machek wrote:
> Hi!
> 
> > >> Let me ask my wife (who is happy using Linux as a regular desktop user)
> > >> how comfortable she would be with triaging kernel bugs...
> > >
> > >That's really up to the distribution, not the main kernel stable. Does
> > >she download and compile the kernels herself? Does she use LEDs?
> > >
> > >The point is, stable is to keep what was working continued working.
> > >If we don't care about introducing a regression, and just want to keep
> > >regressions the same as mainline, why not just go to mainline? That way
> > >you can also get the new features? Mainline already has the mantra to
> > >not break user space. When I work on new features, I sometimes stumble
> > >on bugs with the current features. And some of those fixes require a
> > >rewrite. It was "good enough" before, but every so often could cause a
> > >bug that the new feature would trigger more often. Do we back port that
> > >rewrite? Do we backport fixes to old code that are more likely to be
> > >triggered by new features?
> > >
> > >Ideally, we should be working on getting to no regressions to stable.
> > 
> > This is exactly what we're doing.
> > 
> > If a fix for a bug in -stable introduces a different regression,
> > should we take it or not?
> 
> If a fix for bug introduces regression, would you call it "obviously
> correct"?

I honestly can't believe you all are arguing about this.  We backport
bugfixes to the stable tree.  If those fixes also are buggy we either
apply the fix for that problem that ended up in Linus's tree, or we
revert the patch.  If the fix is not in Linus's tree, sometimes we leave
the "bug" in stable for a bit to apply some pressure on the
developer/maintainer to get it fixed in Linus's tree (that's what I mean
by being "bug compatible".)

This is exactly what we have been doing for over a decade now, why are
people suddenly getting upset?

Oh, I know why, suddenly subsystems that never were taking the time to
mark patches for stable are getting patches backported and are getting
nervous.  The simple way to stop that from happening is to PROPERLY MARK
PATCHES FOR STABLE IN THE FIRST PLACE!

If you do that, then, no "automated" patches will get selected as you
already handled them all.  Or if there are some automated patches
picked, you can easily NAK them (like xfs does as they know better than
everyone else, and honestly, I trust them, and don't run xfs myself), or
do like what I do when it happens to me and go "hey, nice, I missed that
one!"

There, problem solved, if you do that, no more worrying by you at all,
and this thread can properly die.

ugh,

greg k-h

  reply	other threads:[~2018-04-17 10:46 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180409001936.162706-1-alexander.levin@microsoft.com>
2018-04-09  0:19 ` [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes Sasha Levin
2018-04-09  8:22   ` Petr Mladek
2018-04-15 14:42     ` Sasha Levin
2018-04-16 13:30       ` Steven Rostedt
2018-04-16 15:18         ` Linus Torvalds
2018-04-16 15:30           ` Pavel Machek
2018-04-16 15:50             ` Sasha Levin
2018-04-16 16:06               ` Pavel Machek
2018-04-16 16:14                 ` Sasha Levin
2018-04-16 16:22                   ` Steven Rostedt
2018-04-16 16:31                     ` Sasha Levin
2018-04-16 16:47                       ` Steven Rostedt
2018-04-16 16:53                         ` Sasha Levin
2018-04-16 17:00                           ` Pavel Machek
2018-04-17 10:46                             ` Greg KH [this message]
2018-04-17 12:24                               ` Petr Mladek
2018-04-17 12:49                                 ` Michal Hocko
2018-04-17 13:39                                   ` Sasha Levin
2018-04-17 14:22                                     ` Michal Hocko
2018-04-17 14:36                                       ` Sasha Levin
2018-04-17 18:10                                         ` Michal Hocko
2018-04-17 13:45                                 ` Sasha Levin
2018-04-18  8:33                                   ` Petr Mladek
2018-04-16 16:28                   ` Pavel Machek
2018-04-16 16:39                     ` Sasha Levin
2018-04-16 16:42                       ` Pavel Machek
2018-04-16 16:45                         ` Sasha Levin
2018-04-16 16:54                           ` Pavel Machek
2018-04-17 10:50                             ` Greg KH
2018-04-16 17:05                   ` Pavel Machek
2018-04-16 17:16                     ` Sasha Levin
2018-04-16 17:44                       ` Steven Rostedt
2018-04-16 18:17                         ` Sasha Levin
2018-04-16 18:35                           ` Steven Rostedt
2018-04-16 20:17                       ` Jiri Kosina
2018-04-16 20:36                         ` Sasha Levin
2018-04-16 20:43                           ` Jiri Kosina
2018-04-16 21:18                             ` Sasha Levin
2018-04-16 21:28                               ` Jiri Kosina
2018-04-17 10:39                                 ` Greg KH
2018-04-17 11:07                                   ` Michal Hocko
2018-04-17 14:04                                     ` Sasha Levin
2018-04-17 14:15                                       ` Steven Rostedt
2018-04-17 14:36                                         ` Greg KH
2018-04-17 14:36                                       ` Michal Hocko
2018-04-17 14:55                                         ` Sasha Levin
2018-04-17 15:52                                           ` Jiri Kosina
2018-04-17 16:06                                             ` Sasha Levin
2018-05-03 10:04                                               ` Pavel Machek
2018-05-03 13:02                                                 ` Sasha Levin
2018-04-17 16:25                                             ` Mike Galbraith
2018-04-17 11:21                                   ` Jiri Kosina
2018-05-03  9:47                               ` Pavel Machek
2018-05-03 13:06                                 ` Sasha Levin
2018-04-16 16:20                 ` Steven Rostedt
2018-04-16 16:28                   ` Sasha Levin
2018-04-16 16:39                     ` Pavel Machek
2018-04-16 16:43                       ` Sasha Levin
2018-04-16 16:53                         ` Steven Rostedt
2018-04-16 16:58                           ` Pavel Machek
2018-04-16 17:09                           ` Sasha Levin
2018-04-16 17:33                             ` Steven Rostedt
2018-04-16 17:42                               ` Sasha Levin
2018-04-16 18:26                                 ` Steven Rostedt
2018-04-16 18:30                                   ` Linus Torvalds
2018-04-16 18:41                                     ` Steven Rostedt
2018-04-16 18:52                                       ` Linus Torvalds
2018-04-16 19:00                                         ` Linus Torvalds
2018-04-16 19:30                                           ` Steven Rostedt
2018-04-16 19:19                                         ` Linus Torvalds
2018-04-16 19:24                                         ` Steven Rostedt
2018-04-16 19:28                                           ` Linus Torvalds
2018-04-16 19:31                                             ` Linus Torvalds
2018-04-16 19:58                                               ` Steven Rostedt
2018-04-16 19:38                                             ` Steven Rostedt
2018-04-16 19:55                                               ` Linus Torvalds
2018-04-16 20:02                                                 ` Steven Rostedt
2018-04-16 20:17                                                   ` Linus Torvalds
2018-04-16 20:33                                                     ` Jiri Kosina
2018-04-16 21:27                                                     ` Steven Rostedt
2018-04-16 18:35                                   ` Sasha Levin
2018-04-16 18:57                                     ` Steven Rostedt
2018-04-16 15:36           ` Steven Rostedt
2018-04-16 16:02             ` Sasha Levin
2018-04-16 16:10               ` Pavel Machek
2018-04-16 16:12               ` Steven Rostedt
2018-04-16 16:19                 ` Sasha Levin
2018-04-16 16:30                   ` Steven Rostedt
2018-04-16 16:37                     ` Sasha Levin
2018-04-16 17:06                       ` Pavel Machek
2018-04-16 17:23                         ` Sasha Levin
2018-04-17 11:41                           ` Jan Kara
2018-04-17 13:31                             ` Sasha Levin
2018-04-17 15:55                               ` Jan Kara
2018-04-17 16:19                                 ` Sasha Levin
2018-04-17 17:57                                   ` Jan Kara
2018-04-17 18:28                                     ` Sasha Levin
2018-05-03  9:36                                   ` Pavel Machek
2018-05-03 13:28                                     ` Sasha Levin
2018-05-03  9:32                           ` Pavel Machek
2018-05-03 13:30                             ` Sasha Levin
2018-04-19 11:41                   ` Thomas Backlund
2018-04-19 13:59                     ` Greg KH
2018-04-19 14:05                       ` Jan Kara
2018-04-19 14:22                         ` Greg KH
2018-04-19 15:16                           ` Thomas Backlund
2018-04-19 15:57                             ` Greg KH
2018-04-19 16:25                               ` Thomas Backlund
2018-04-19 16:41                           ` Greg KH
2018-04-19 15:04                       ` Thomas Backlund
2018-04-19 15:09                         ` Sasha Levin
2018-04-19 16:20                           ` Thomas Backlund
2018-04-16 15:39           ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417104637.GD8445@kroah.com \
    --to=greg@kroah.com \
    --cc=Alexander.Levin@microsoft.com \
    --cc=akpm@linux-foundation.org \
    --cc=byungchul.park@lge.com \
    --cc=dave.hansen@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mgorman@suse.de \
    --cc=mhocko@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).