From: David Hildenbrand <david@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Oscar Salvador <osalvador@techadventures.net>,
Kate Stewart <kstewart@linuxfoundation.org>,
Jaewon Kim <jaewon31.kim@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v1 02/10] mm/page_ext.c: support online/offline of memory < section size
Date: Wed, 23 May 2018 17:11:43 +0200 [thread overview]
Message-ID: <20180523151151.6730-3-david@redhat.com> (raw)
In-Reply-To: <20180523151151.6730-1-david@redhat.com>
Right now, we would free the extended page data if parts of a section
are offlined or if onlining is aborted, although still some pages are
online.
We can simply check if the section is online to see if we are allowed to
free. init_section_page_ext() already takes care of the allocation part
for sub sections.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Oscar Salvador <osalvador@techadventures.net>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Cc: Jaewon Kim <jaewon31.kim@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
mm/page_ext.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/mm/page_ext.c b/mm/page_ext.c
index 5295ef331165..71a025128dac 100644
--- a/mm/page_ext.c
+++ b/mm/page_ext.c
@@ -320,7 +320,9 @@ static int __meminit online_page_ext(unsigned long start_pfn,
/* rollback */
for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION)
- __free_page_ext(pfn);
+ /* still online? nothing to do then */
+ if (!online_section_nr(pfn_to_section_nr(pfn)))
+ __free_page_ext(pfn);
return -ENOMEM;
}
@@ -334,7 +336,10 @@ static int __meminit offline_page_ext(unsigned long start_pfn,
end = SECTION_ALIGN_UP(start_pfn + nr_pages);
for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION)
- __free_page_ext(pfn);
+ /* still online? nothing to do then */
+ if (!online_section_nr(pfn_to_section_nr(pfn)))
+ __free_page_ext(pfn);
+
return 0;
}
--
2.17.0
next prev parent reply other threads:[~2018-05-23 15:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 15:11 [PATCH v1 00/10] mm: online/offline 4MB chunks controlled by device driver David Hildenbrand
2018-05-23 15:11 ` [PATCH v1 01/10] mm: introduce and use PageOffline() David Hildenbrand
2018-05-23 15:11 ` David Hildenbrand [this message]
2018-05-23 15:11 ` [PATCH v1 03/10] kasan: prepare for online/offline of different start/size David Hildenbrand
2018-05-23 15:11 ` [PATCH v1 04/10] kdump: include PAGE_OFFLINE_MAPCOUNT_VALUE in VMCOREINFO David Hildenbrand
2018-05-23 15:11 ` [PATCH v1 05/10] mm/memory_hotplug: limit offline_pages() to sizes we can actually handle David Hildenbrand
2018-05-23 15:11 ` [PATCH v1 06/10] mm/memory_hotplug: onlining pages can only fail due to notifiers David Hildenbrand
2018-05-23 15:11 ` [PATCH v1 07/10] mm/memory_hotplug: print only with DEBUG_VM in online/offline_pages() David Hildenbrand
2018-05-23 15:11 ` [PATCH v1 08/10] mm/memory_hotplug: allow to control onlining/offlining of memory by a driver David Hildenbrand
2018-05-23 15:11 ` [PATCH v1 09/10] mm/memory_hotplug: teach offline_pages() to not try forever David Hildenbrand
2018-05-24 14:39 ` Michal Hocko
2018-05-24 20:36 ` David Hildenbrand
2018-05-23 15:11 ` [PATCH v1 10/10] mm/memory_hotplug: allow online/offline memory by a kernel module David Hildenbrand
2018-05-23 19:51 ` Christoph Hellwig
2018-05-24 5:59 ` David Hildenbrand
2018-05-24 7:53 ` [PATCH v1 00/10] mm: online/offline 4MB chunks controlled by device driver Michal Hocko
2018-05-24 8:31 ` David Hildenbrand
2018-05-24 8:56 ` Dave Young
2018-05-24 9:14 ` David Hildenbrand
2018-05-28 8:28 ` Dave Young
2018-05-28 10:03 ` David Hildenbrand
2018-05-24 9:31 ` Michal Hocko
2018-05-24 10:45 ` David Hildenbrand
2018-05-24 12:03 ` Michal Hocko
2018-05-24 14:04 ` David Hildenbrand
2018-05-24 14:22 ` Michal Hocko
2018-05-24 21:07 ` David Hildenbrand
2018-06-11 11:53 ` David Hildenbrand
2018-06-11 11:56 ` Michal Hocko
2018-06-11 12:33 ` David Hildenbrand
2018-07-16 19:48 ` David Hildenbrand
2018-07-16 20:05 ` Michal Hocko
2018-07-18 9:56 ` David Hildenbrand
2018-07-18 11:23 ` Michal Hocko
2018-07-18 13:19 ` Michal Hocko
2018-07-18 13:39 ` David Hildenbrand
2018-07-18 13:43 ` Michal Hocko
2018-07-18 13:47 ` David Hildenbrand
2018-07-18 13:56 ` Michal Hocko
2018-05-25 15:08 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523151151.6730-3-david@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaewon31.kim@samsung.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@techadventures.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).