From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id 7E0C96B0006 for ; Wed, 30 May 2018 19:02:25 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id b31-v6so12162522plb.5 for ; Wed, 30 May 2018 16:02:25 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net. [150.101.137.129]) by mx.google.com with ESMTP id d5-v6si8945179pln.567.2018.05.30.16.02.23 for ; Wed, 30 May 2018 16:02:24 -0700 (PDT) Date: Thu, 31 May 2018 09:02:18 +1000 From: Dave Chinner Subject: Re: [PATCH 03/13] mm: return an unsigned int from __do_page_cache_readahead Message-ID: <20180530230218.GA10363@dastard> References: <20180530095813.31245-1-hch@lst.de> <20180530095813.31245-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180530095813.31245-4-hch@lst.de> Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org On Wed, May 30, 2018 at 11:58:03AM +0200, Christoph Hellwig wrote: > We never return an error, so switch to returning an unsigned int. Most > callers already did implicit casts to an unsigned type, and the one that > didn't can be simplified now. > > Suggested-by: Matthew Wilcox > Signed-off-by: Christoph Hellwig > Reviewed-by: Darrick J. Wong Makes sense. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com