From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id 7C6976B0007 for ; Wed, 30 May 2018 19:03:10 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id 89-v6so12072888plb.18 for ; Wed, 30 May 2018 16:03:10 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net. [150.101.137.129]) by mx.google.com with ESMTP id p2-v6si13633485pls.551.2018.05.30.16.03.08 for ; Wed, 30 May 2018 16:03:09 -0700 (PDT) Date: Thu, 31 May 2018 09:02:59 +1000 From: Dave Chinner Subject: Re: [PATCH 04/13] mm: split ->readpages calls to avoid non-contiguous pages lists Message-ID: <20180530230259.GB10363@dastard> References: <20180530095813.31245-1-hch@lst.de> <20180530095813.31245-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180530095813.31245-5-hch@lst.de> Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org On Wed, May 30, 2018 at 11:58:04AM +0200, Christoph Hellwig wrote: > That way file systems don't have to go spotting for non-contiguous pages > and work around them. It also kicks off I/O earlier, allowing it to > finish earlier and reduce latency. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Darrick J. Wong Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com