From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, kirill.shutemov@linux.intel.com,
mhocko@suse.com, riel@redhat.com
Subject: Re: [PATCH] mm: Check for SIGKILL inside dup_mmap() loop.
Date: Fri, 8 Jun 2018 10:05:03 -0700 [thread overview]
Message-ID: <20180608170503.GA29260@bombadil.infradead.org> (raw)
In-Reply-To: <20180607150546.1c7db21f70221008e14b8bb8@linux-foundation.org>
On Thu, Jun 07, 2018 at 03:05:46PM -0700, Andrew Morton wrote:
> [akpm@linux-foundation.org: add comment]
Can I fix the comment? ;-)
> @@ -440,6 +440,14 @@ static __latent_entropy int dup_mmap(str
> continue;
> }
> charge = 0;
> + /*
> + * Don't duplicate many vmas if we've been oom-killed (for
> + * example)
> + */
/*
* No point in continuing if we're just going to die at
* the end of the fork. This may happen due to being OOM.
*/
> + if (fatal_signal_pending(current)) {
> + retval = -EINTR;
> + goto out;
> + }
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
prev parent reply other threads:[~2018-06-08 17:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 11:27 [PATCH] mm: Check for SIGKILL inside dup_mmap() loop Tetsuo Handa
2018-03-29 21:30 ` Andrew Morton
2018-03-30 10:34 ` Tetsuo Handa
2018-04-03 12:14 ` Matthew Wilcox
2018-04-03 12:19 ` Michal Hocko
2018-04-03 12:25 ` Matthew Wilcox
2018-04-03 14:54 ` Tetsuo Handa
2018-04-03 12:29 ` Tetsuo Handa
2018-04-03 13:06 ` Michal Hocko
2018-04-03 11:16 ` Michal Hocko
2018-04-03 11:32 ` Tetsuo Handa
2018-04-03 11:38 ` Michal Hocko
2018-04-03 11:58 ` Matthew Wilcox
2018-04-03 12:08 ` Michal Hocko
2018-04-07 10:38 ` Tetsuo Handa
2018-04-18 21:44 ` Andrew Morton
2018-04-19 1:54 ` Tetsuo Handa
2018-04-19 2:32 ` Andrew Morton
2018-06-07 22:05 ` Andrew Morton
2018-06-08 17:05 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608170503.GA29260@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=riel@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).