From: kbuild test robot <lkp@intel.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Roman Gushchin <guro@fb.com>, Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-api@vger.kernel.org, Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@techsingularity.net>,
Matthew Wilcox <willy@infradead.org>,
Vijayanand Jitta <vjitta@codeaurora.org>,
Laura Abbott <labbott@redhat.com>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH v2 5/7] mm: rename and change semantics of nr_indirectly_reclaimable_bytes
Date: Wed, 20 Jun 2018 19:23:54 +0800 [thread overview]
Message-ID: <201806201923.mC5ZpigB%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180618091808.4419-6-vbabka@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 3123 bytes --]
Hi Vlastimil,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.18-rc1 next-20180619]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vlastimil-Babka/kmalloc-reclaimable-caches/20180618-172912
base: git://git.cmpxchg.org/linux-mmotm.git master
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/staging//android/ion/ion_page_pool.c: In function 'ion_page_pool_remove':
>> drivers/staging//android/ion/ion_page_pool.c:56:40: error: 'NR_INDIRECTLY_RECLAIMABLE_BYTES' undeclared (first use in this function)
mod_node_page_state(page_pgdat(page), NR_INDIRECTLY_RECLAIMABLE_BYTES,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging//android/ion/ion_page_pool.c:56:40: note: each undeclared identifier is reported only once for each function it appears in
vim +/NR_INDIRECTLY_RECLAIMABLE_BYTES +56 drivers/staging//android/ion/ion_page_pool.c
0214c7f2 Rebecca Schultz Zavin 2013-12-13 40
0fb9b815 Rebecca Schultz Zavin 2013-12-13 41 static struct page *ion_page_pool_remove(struct ion_page_pool *pool, bool high)
0214c7f2 Rebecca Schultz Zavin 2013-12-13 42 {
0214c7f2 Rebecca Schultz Zavin 2013-12-13 43 struct page *page;
0214c7f2 Rebecca Schultz Zavin 2013-12-13 44
0fb9b815 Rebecca Schultz Zavin 2013-12-13 45 if (high) {
0fb9b815 Rebecca Schultz Zavin 2013-12-13 46 BUG_ON(!pool->high_count);
38c003b1 Heesub Shin 2014-05-28 47 page = list_first_entry(&pool->high_items, struct page, lru);
0fb9b815 Rebecca Schultz Zavin 2013-12-13 48 pool->high_count--;
0fb9b815 Rebecca Schultz Zavin 2013-12-13 49 } else {
0fb9b815 Rebecca Schultz Zavin 2013-12-13 50 BUG_ON(!pool->low_count);
38c003b1 Heesub Shin 2014-05-28 51 page = list_first_entry(&pool->low_items, struct page, lru);
0fb9b815 Rebecca Schultz Zavin 2013-12-13 52 pool->low_count--;
0fb9b815 Rebecca Schultz Zavin 2013-12-13 53 }
0214c7f2 Rebecca Schultz Zavin 2013-12-13 54
38c003b1 Heesub Shin 2014-05-28 55 list_del(&page->lru);
06cd8a61 Andrew Morton 2018-06-15 @56 mod_node_page_state(page_pgdat(page), NR_INDIRECTLY_RECLAIMABLE_BYTES,
06cd8a61 Andrew Morton 2018-06-15 57 -(1 << (PAGE_SHIFT + pool->order)));
0214c7f2 Rebecca Schultz Zavin 2013-12-13 58 return page;
0214c7f2 Rebecca Schultz Zavin 2013-12-13 59 }
0214c7f2 Rebecca Schultz Zavin 2013-12-13 60
:::::: The code at line 56 was first introduced by commit
:::::: 06cd8a610861a7ea0be1ff627fd8d6d6b3f62ca0 origin
:::::: TO: Andrew Morton <akpm@linux-foundation.org>
:::::: CC: Johannes Weiner <hannes@cmpxchg.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64661 bytes --]
next prev parent reply other threads:[~2018-06-20 11:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 9:18 [PATCH v2 0/7] kmalloc-reclaimable caches Vlastimil Babka
2018-06-18 9:18 ` [PATCH v2 1/7] mm, slab: combine kmalloc_caches and kmalloc_dma_caches Vlastimil Babka
2018-06-18 9:18 ` [PATCH v2 2/7] mm, slab/slub: introduce kmalloc-reclaimable caches Vlastimil Babka
2018-06-18 9:18 ` [PATCH v2 3/7] mm, slab: allocate off-slab freelists as reclaimable when appropriate Vlastimil Babka
2018-06-18 9:18 ` [PATCH v2 4/7] dcache: allocate external names from reclaimable kmalloc caches Vlastimil Babka
2018-06-18 9:18 ` [PATCH v2 5/7] mm: rename and change semantics of nr_indirectly_reclaimable_bytes Vlastimil Babka
2018-06-20 11:23 ` kbuild test robot [this message]
2018-06-29 15:37 ` Vlastimil Babka
2018-06-29 21:12 ` Roman Gushchin
2018-06-30 10:09 ` Vlastimil Babka
2018-07-02 16:52 ` Roman Gushchin
2018-07-17 8:44 ` Vlastimil Babka
2018-07-17 18:54 ` Roman Gushchin
2018-07-17 19:11 ` Vlastimil Babka
2018-06-18 9:18 ` [PATCH v2 6/7] mm, proc: add KReclaimable to /proc/meminfo Vlastimil Babka
2018-06-18 21:33 ` Andrew Morton
2018-06-19 7:30 ` Vlastimil Babka
2018-06-19 8:13 ` Minchan Kim
2018-06-19 12:44 ` Vlastimil Babka
2018-06-18 9:18 ` [PATCH v2 7/7] mm, slab: shorten kmalloc cache names for large sizes Vlastimil Babka
2018-06-19 7:54 ` [PATCH v2 0/7] kmalloc-reclaimable caches Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201806201923.mC5ZpigB%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=labbott@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=sumit.semwal@linaro.org \
--cc=vbabka@suse.cz \
--cc=vjitta@codeaurora.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).