From: Michal Hocko <mhocko@kernel.org>
To: Greg Thelen <gthelen@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg, oom: move out_of_memory back to the charge path
Date: Fri, 29 Jun 2018 09:21:32 +0200 [thread overview]
Message-ID: <20180629072132.GA13860@dhcp22.suse.cz> (raw)
In-Reply-To: <xr93in62jy8k.fsf@gthelen.svl.corp.google.com>
On Thu 28-06-18 16:19:07, Greg Thelen wrote:
> Michal Hocko <mhocko@kernel.org> wrote:
[...]
> > + if (mem_cgroup_out_of_memory(memcg, mask, order))
> > + return OOM_SUCCESS;
> > +
> > + WARN(1,"Memory cgroup charge failed because of no reclaimable memory! "
> > + "This looks like a misconfiguration or a kernel bug.");
>
> I'm not sure here if the warning should here or so strongly worded. It
> seems like the current task could be oom reaped with MMF_OOM_SKIP and
> thus mem_cgroup_out_of_memory() will return false. So there's nothing
> alarming in that case.
If the task is reaped then its charges should be released as well and
that means that we should get below the limit. Sure there is some room
for races but this should be still unlikely. Maybe I am just
underestimating though.
What would you suggest instead?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-06-29 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 15:11 [PATCH] memcg, oom: move out_of_memory back to the charge path Michal Hocko
2018-06-28 23:19 ` Greg Thelen
2018-06-29 7:21 ` Michal Hocko [this message]
2018-06-29 18:59 ` Greg Thelen
2018-07-02 10:03 ` Michal Hocko
2018-07-03 7:08 ` Greg Thelen
2018-07-03 7:16 ` Michal Hocko
2018-07-03 23:29 ` Greg Thelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629072132.GA13860@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).