From: Oscar Salvador <osalvador@techadventures.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pavel Tatashin <pasha.tatashin@oracle.com>,
steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com,
mhocko@suse.com, linux-mm@kvack.org, dan.j.williams@intel.com,
jack@suse.cz, jglisse@redhat.com, jrdr.linux@gmail.com,
bhe@redhat.com, gregkh@linuxfoundation.org, vbabka@suse.cz,
richard.weiyang@gmail.com, dave.hansen@intel.com,
rientjes@google.com, mingo@kernel.org
Subject: Re: [PATCH v4 0/3] sparse_init rewrite
Date: Tue, 10 Jul 2018 07:59:57 +0200 [thread overview]
Message-ID: <20180710055957.GA7380@techadventures.net> (raw)
In-Reply-To: <20180709142928.c8af4a1ddf80c407fe66b224@linux-foundation.org>
On Mon, Jul 09, 2018 at 02:29:28PM -0700, Andrew Morton wrote:
> On Mon, 9 Jul 2018 13:53:09 -0400 Pavel Tatashin <pasha.tatashin@oracle.com> wrote:
>
> > In sparse_init() we allocate two large buffers to temporary hold usemap and
> > memmap for the whole machine. However, we can avoid doing that if we
> > changed sparse_init() to operated on per-node bases instead of doing it on
> > the whole machine beforehand.
> >
> > As shown by Baoquan
> > http://lkml.kernel.org/r/20180628062857.29658-1-bhe@redhat.com
> >
> > The buffers are large enough to cause machine stop to boot on small memory
> > systems.
> >
> > These patches should be applied on top of Baoquan's work, as
> > CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER is removed in that work.
> >
> > For the ease of review, I split this work so the first patch only adds new
> > interfaces, the second patch enables them, and removes the old ones.
>
> This clashes pretty significantly with patches from Baoquan and Oscar:
>
> mm-sparse-make-sparse_init_one_section-void-and-remove-check.patch
> mm-sparse-make-sparse_init_one_section-void-and-remove-check-fix.patch
> mm-sparse-make-sparse_init_one_section-void-and-remove-check-fix-2.patch
Does this patchset still clash with those patches?
If so, since those patches are already in the -mm tree, would it be better to re-base the patchset on top of that?
Thanks
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2018-07-10 6:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 17:53 [PATCH v4 0/3] sparse_init rewrite Pavel Tatashin
2018-07-09 17:53 ` [PATCH v4 1/3] mm/sparse: add sparse_init_nid() Pavel Tatashin
2018-07-09 17:53 ` [PATCH v4 2/3] mm/sparse: start using sparse_init_nid(), and remove old code Pavel Tatashin
2018-07-09 17:53 ` [PATCH v4 3/3] mm/sparse: refactor sparse vmemmap buffer allocations Pavel Tatashin
2018-07-09 21:29 ` [PATCH v4 0/3] sparse_init rewrite Andrew Morton
2018-07-09 22:54 ` Pavel Tatashin
2018-07-09 23:56 ` Baoquan He
2018-07-10 0:08 ` Andrew Morton
2018-07-10 5:59 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710055957.GA7380@techadventures.net \
--to=osalvador@techadventures.net \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
--cc=steven.sistare@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).