* [PATCH v2 0/7] swap: THP optimizing refactoring
@ 2018-07-17 0:51 Huang, Ying
0 siblings, 0 replies; 4+ messages in thread
From: Huang, Ying @ 2018-07-17 0:51 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-mm, linux-kernel, Dave Hansen, Michal Hocko,
Johannes Weiner, Shaohua Li, Hugh Dickins, Minchan Kim,
Rik van Riel, Daniel Jordan, Dan Williams
This patchset is based on 2018-07-13 head of mmotm tree.
Now the THP (Transparent Huge Page) swap optimizing is implemented in
the way like below,
#ifdef CONFIG_THP_SWAP
huge_function(...)
{
}
#else
normal_function(...)
{
}
#endif
general_function(...)
{
if (huge)
return thp_function(...);
else
return normal_function(...);
}
As pointed out by Dave Hansen, this will,
1. Created a new, wholly untested code path for huge page
2. Created two places to patch bugs
3. Are not reusing code when possible
This patchset is to address these problems via merging huge/normal
code path/functions if possible.
One concern is that this may cause code size to dilate when
!CONFIG_TRANSPARENT_HUGEPAGE. The data shows that most refactoring
will only cause quite slight code size increase.
Best Regards,
Huang, Ying
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 0/7] swap: THP optimizing refactoring
@ 2018-07-17 0:55 Huang, Ying
2018-07-17 15:17 ` Daniel Jordan
0 siblings, 1 reply; 4+ messages in thread
From: Huang, Ying @ 2018-07-17 0:55 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-mm, linux-kernel, Dave Hansen, Michal Hocko,
Johannes Weiner, Shaohua Li, Hugh Dickins, Minchan Kim,
Rik van Riel, Daniel Jordan, Dan Williams
This patchset is based on 2018-07-13 head of mmotm tree.
Now the THP (Transparent Huge Page) swap optimizing is implemented in
the way like below,
#ifdef CONFIG_THP_SWAP
huge_function(...)
{
}
#else
normal_function(...)
{
}
#endif
general_function(...)
{
if (huge)
return thp_function(...);
else
return normal_function(...);
}
As pointed out by Dave Hansen, this will,
1. Created a new, wholly untested code path for huge page
2. Created two places to patch bugs
3. Are not reusing code when possible
This patchset is to address these problems via merging huge/normal
code path/functions if possible.
One concern is that this may cause code size to dilate when
!CONFIG_TRANSPARENT_HUGEPAGE. The data shows that most refactoring
will only cause quite slight code size increase.
Best Regards,
Huang, Ying
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/7] swap: THP optimizing refactoring
2018-07-17 0:55 Huang, Ying
@ 2018-07-17 15:17 ` Daniel Jordan
2018-07-18 2:56 ` Huang, Ying
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Jordan @ 2018-07-17 15:17 UTC (permalink / raw)
To: Huang, Ying
Cc: Andrew Morton, linux-mm, linux-kernel, Dave Hansen, Michal Hocko,
Johannes Weiner, Shaohua Li, Hugh Dickins, Minchan Kim,
Rik van Riel, Daniel Jordan, Dan Williams
On Tue, Jul 17, 2018 at 08:55:49AM +0800, Huang, Ying wrote:
> This patchset is based on 2018-07-13 head of mmotm tree.
Looks good.
Still think patch 7 would be easier to review if split into two logical
changes. Either way, though.
For the series,
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/7] swap: THP optimizing refactoring
2018-07-17 15:17 ` Daniel Jordan
@ 2018-07-18 2:56 ` Huang, Ying
0 siblings, 0 replies; 4+ messages in thread
From: Huang, Ying @ 2018-07-18 2:56 UTC (permalink / raw)
To: Daniel Jordan
Cc: Andrew Morton, linux-mm, linux-kernel, Dave Hansen, Michal Hocko,
Johannes Weiner, Shaohua Li, Hugh Dickins, Minchan Kim,
Rik van Riel, Dan Williams
Daniel Jordan <daniel.m.jordan@oracle.com> writes:
> On Tue, Jul 17, 2018 at 08:55:49AM +0800, Huang, Ying wrote:
>> This patchset is based on 2018-07-13 head of mmotm tree.
>
> Looks good.
>
> Still think patch 7 would be easier to review if split into two logical
> changes. Either way, though.
>
> For the series,
> Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Thanks a lot for your review!
Best Regards,
Huang, Ying
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-18 2:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-17 0:51 [PATCH v2 0/7] swap: THP optimizing refactoring Huang, Ying
-- strict thread matches above, loose matches on Subject: below --
2018-07-17 0:55 Huang, Ying
2018-07-17 15:17 ` Daniel Jordan
2018-07-18 2:56 ` Huang, Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).