From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: Richard Kuo <rkuo@codeaurora.org>
Cc: Michal Hocko <mhocko@kernel.org>,
linux-hexagon@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hexagon: switch to NO_BOOTMEM
Date: Wed, 25 Jul 2018 08:28:09 +0300 [thread overview]
Message-ID: <20180725052809.GA25188@rapoport-lnx> (raw)
In-Reply-To: <20180725021255.GF12771@codeaurora.org>
On Tue, Jul 24, 2018 at 09:12:55PM -0500, Richard Kuo wrote:
> On Tue, Jul 24, 2018 at 08:47:04AM +0300, Mike Rapoport wrote:
> > On Mon, Jul 23, 2018 at 04:23:39PM -0500, Richard Kuo wrote:
> > >
> > > On Mon, Jul 16, 2018 at 10:43:18AM +0300, Mike Rapoport wrote:
> > > > This patch adds registration of the system memory with memblock, eliminates
> > > > bootmem initialization and converts early memory reservations from bootmem
> > > > to memblock.
> > > >
> > > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
> > >
> > > Sorry for the delay, and thanks for this patch.
> > >
> > > I think the first memblock_reserve should use ARCH_PFN_OFFSET instead of
> > > PHYS_OFFSET.
> >
> > memblock_reserve gets physical address rather than a pfn.
> >
> > If I read arch/hexagon/include/asm/mem-layout.h correctly, the PHYS_OFFSET
> > *is* the physical address of the RAM and ARCH_PFN_OFFSET is the first pfn:
> >
> > #define PHYS_PFN_OFFSET (PHYS_OFFSET >> PAGE_SHIFT)
> > #define ARCH_PFN_OFFSET PHYS_PFN_OFFSET
> >
> > Did I miss something?
>
> Sorry, I should have been more clear. In the size calculation, it's
> subtracting the unshifted PHYS_OFFSET from the start page number, which
> I'm pretty sure is wrong.
Yeah, you're right. I've missed that one.
> Thanks,
> Richard Kuo
>
>
> --
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2018-07-25 5:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 7:43 [PATCH] hexagon: switch to NO_BOOTMEM Mike Rapoport
2018-07-23 21:23 ` Richard Kuo
2018-07-24 5:47 ` Mike Rapoport
2018-07-25 2:12 ` Richard Kuo
2018-07-25 5:28 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725052809.GA25188@rapoport-lnx \
--to=rppt@linux.vnet.ibm.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).