From: Oscar Salvador <osalvador@techadventures.net>
To: akpm@linux-foundation.org
Cc: mhocko@suse.com, vbabka@suse.cz, pasha.tatashin@oracle.com,
mgorman@techsingularity.net, aaron.lu@intel.com,
iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, dan.j.williams@intel.com,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v3 5/5] mm/page_alloc: Introduce memhotplug version of free_area_init_core
Date: Thu, 26 Jul 2018 14:02:24 +0200 [thread overview]
Message-ID: <20180726120224.GA8302@techadventures.net> (raw)
In-Reply-To: <20180725220144.11531-6-osalvador@techadventures.net>
On Thu, Jul 26, 2018 at 12:01:44AM +0200, osalvador@techadventures.net wrote:
> - */
> + * When memory is hot-added, all the memory is in offline state. So
> + * clear all zones' present_pages because they will be updated in
> + * online_pages() and offline_pages().
> + */
Sigh..., I should have run checkpatch. Tabs are missing there
> +void __paginginit free_area_init_core_hotplug(int nid)
> +{
> + enum zone_type j;
> + pg_data_t *pgdat = NODE_DATA(nid);
> +
> + pgdat_init_internals(pgdat);
> + for(j = 0; j < MAX_NR_ZONES; j++) {
And missing a space here.
Sorry, I will fix all this up in the next re-submission once I got feedback.
Thanks
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2018-07-26 12:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 22:01 [PATCH v3 0/5] Refactor free_area_init_core and add free_area_init_core_hotplug osalvador
2018-07-25 22:01 ` [PATCH v3 1/5] mm/page_alloc: Move ifdefery out of free_area_init_core osalvador
2018-07-25 22:01 ` [PATCH v3 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid() osalvador
2018-07-26 8:05 ` Michal Hocko
2018-07-26 8:12 ` Oscar Salvador
2018-07-26 15:14 ` Pavel Tatashin
2018-07-26 16:43 ` Michal Hocko
2018-07-26 17:18 ` Pavel Tatashin
2018-07-26 17:52 ` Michal Hocko
2018-07-26 17:55 ` Pavel Tatashin
2018-07-26 19:15 ` Oscar Salvador
2018-07-25 22:01 ` [PATCH v3 3/5] mm/page_alloc: Inline function to handle CONFIG_DEFERRED_STRUCT_PAGE_INIT osalvador
2018-07-26 15:17 ` Pavel Tatashin
2018-07-25 22:01 ` [PATCH v3 4/5] mm/page_alloc: Move initialization of node and zones to an own function osalvador
2018-07-26 8:12 ` Michal Hocko
2018-07-26 15:35 ` Pavel Tatashin
2018-07-26 19:15 ` Oscar Salvador
2018-07-25 22:01 ` [PATCH v3 5/5] mm/page_alloc: Introduce memhotplug version of free_area_init_core osalvador
2018-07-26 7:38 ` Oscar Salvador
2018-07-26 12:02 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726120224.GA8302@techadventures.net \
--to=osalvador@techadventures.net \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).