From: Matthew Wilcox <willy@infradead.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
linux-mm@kvack.org
Subject: Re: [PATCH resend] powerpc/64s: fix page table fragment refcount race vs speculative references
Date: Fri, 27 Jul 2018 06:41:56 -0700 [thread overview]
Message-ID: <20180727134156.GA13348@bombadil.infradead.org> (raw)
In-Reply-To: <20180727114817.27190-1-npiggin@gmail.com>
On Fri, Jul 27, 2018 at 09:48:17PM +1000, Nicholas Piggin wrote:
> The page table fragment allocator uses the main page refcount racily
> with respect to speculative references. A customer observed a BUG due
> to page table page refcount underflow in the fragment allocator. This
> can be caused by the fragment allocator set_page_count stomping on a
> speculative reference, and then the speculative failure handler
> decrements the new reference, and the underflow eventually pops when
> the page tables are freed.
Oof. Can't you fix this instead by using page_ref_add() instead of
set_page_count()?
> Any objection to the struct page change to grab the arch specific
> page table page word for powerpc to use? If not, then this should
> go via powerpc tree because it's inconsequential for core mm.
I want (eventually) to get to the point where every struct page carries
a pointer to the struct mm that it belongs to. It's good for debugging
as well as handling memory errors in page tables.
next prev parent reply other threads:[~2018-07-27 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 11:48 [PATCH resend] powerpc/64s: fix page table fragment refcount race vs speculative references Nicholas Piggin
2018-07-27 13:41 ` Matthew Wilcox [this message]
2018-07-27 14:29 ` Nicholas Piggin
2018-07-27 15:38 ` Matthew Wilcox
2018-07-27 16:32 ` Nicholas Piggin
2018-07-31 11:42 ` Michael Ellerman
2018-08-01 2:45 ` Nicholas Piggin
2018-08-08 14:26 ` [resend] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727134156.GA13348@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).