From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by kanga.kvack.org (Postfix) with ESMTP id 6B54F6B0003 for ; Mon, 30 Jul 2018 13:59:38 -0400 (EDT) Received: by mail-wr1-f70.google.com with SMTP id q18-v6so10123929wrr.12 for ; Mon, 30 Jul 2018 10:59:38 -0700 (PDT) Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz. [195.113.26.193]) by mx.google.com with ESMTPS id z5-v6si134507wmd.93.2018.07.30.10.59.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jul 2018 10:59:37 -0700 (PDT) Date: Mon, 30 Jul 2018 19:59:36 +0200 From: Pavel Machek Subject: Re: [PATCH 0/10] psi: pressure stall information for CPU, memory, and IO v2 Message-ID: <20180730175936.GA2416@amd> References: <20180712172942.10094-1-hannes@cmpxchg.org> <20180727220123.GB18879@amd> <20180730154035.GC4567@cmpxchg.org> <20180730173940.GB881@amd> <20180730175120.GJ1206094@devbig004.ftw2.facebook.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <20180730175120.GJ1206094@devbig004.ftw2.facebook.com> Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: Johannes Weiner , Ingo Molnar , Peter Zijlstra , Andrew Morton , Linus Torvalds , Suren Baghdasaryan , Vinayak Menon , Christopher Lameter , Mike Galbraith , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2018-07-30 10:51:20, Tejun Heo wrote: > Hello, >=20 > On Mon, Jul 30, 2018 at 07:39:40PM +0200, Pavel Machek wrote: > > > I'd rather have the internal config symbol match the naming scheme in > > > the code, where psi is a shorter, unique token as copmared to e.g. > > > pressure, press, prsr, etc. > >=20 > > I'd do "pressure", really. Yes, psi is shorter, but I'd say that > > length is not really important there. >=20 > This is an extreme bikeshedding without any relevance. You can make > suggestions but please lay it to the rest. There isn't any general > consensus against the current name and you're just trying to push your > favorite name without proper justifications after contributing nothing > to the project. Please stop. Its true I have no interest in psi. But I'm trying to use same kernel you are trying to "improve" and I was confused enough by seing "CONFIG_PSI". And yes, my association was "pounds per square inch" and "what is it doing here". So I'm asking you to change the name. USB is well known acronym, so it is okay to have CONFIG_USB. PSI is also well known -- but means something else. And the code kind-of acknowledges that acronym is unknown, by having /proc/pressure. So please just fix it. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAltfUggACgkQMOfwapXb+vKAvgCfQE/kZZxaNG37MoP55aHmHCeO XIEAn0L3Iqd7uuiqMrYzFwuLGN0MMs/N =bq/s -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--