[mmotm:master 208/394] mm/page_alloc.c:6245:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'zone_init_internals'

[mmotm:master 208/394] mm/page_alloc.c:6245:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'zone_init_internals'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2676 bytes --]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   b1da01df1aa700864692a49a7007fc96cc1da7d9
commit: e3dcfdaca81e86f21335a0b6d39162ad574c8574 [208/394] mm/page_alloc: Introduce free_area_init_core_hotplug
config: x86_64-fedora-25 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        git checkout e3dcfdaca81e86f21335a0b6d39162ad574c8574
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the mmotm/master HEAD b1da01df1aa700864692a49a7007fc96cc1da7d9 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

>> mm/page_alloc.c:6245:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'zone_init_internals'
    static void __paginginit zone_init_internals(struct zone *zone, enum zone_type idx, int nid,
                             ^~~~~~~~~~~~~~~~~~~
   mm/page_alloc.c: In function 'free_area_init_core_hotplug':
>> mm/page_alloc.c:6272:3: error: implicit declaration of function 'zone_init_internals'; did you mean 'pgdat_init_internals'? [-Werror=implicit-function-declaration]
      zone_init_internals(&pgdat->node_zones[z], z, nid, 0);
      ^~~~~~~~~~~~~~~~~~~
      pgdat_init_internals
   At top level:
   mm/page_alloc.c:5721:23: warning: 'zone_pcp_init' defined but not used [-Wunused-function]
    static __meminit void zone_pcp_init(struct zone *zone)
                          ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +6245 mm/page_alloc.c

  6244	
> 6245	static void __paginginit zone_init_internals(struct zone *zone, enum zone_type idx, int nid,
  6246								unsigned long remaining_pages)
  6247	{
  6248		zone->managed_pages = remaining_pages;
  6249		zone_set_nid(zone, nid);
  6250		zone->name = zone_names[idx];
  6251		zone->zone_pgdat = NODE_DATA(nid);
  6252		spin_lock_init(&zone->lock);
  6253		zone_seqlock_init(zone);
  6254		zone_pcp_init(zone);
  6255	}
  6256	
  6257	/*
  6258	 * Set up the zone data structures
  6259	 * - init pgdat internals
  6260	 * - init all zones belonging to this node
  6261	 *
  6262	 * NOTE: this function is only called during memory hotplug
  6263	 */
  6264	#ifdef CONFIG_MEMORY_HOTPLUG
  6265	void __ref free_area_init_core_hotplug(int nid)
  6266	{
  6267		enum zone_type z;
  6268		pg_data_t *pgdat = NODE_DATA(nid);
  6269	
  6270		pgdat_init_internals(pgdat);
  6271		for (z = 0; z < MAX_NR_ZONES; z++)
> 6272			zone_init_internals(&pgdat->node_zones[z], z, nid, 0);
  6273	}
  6274	#endif
  6275	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48120 bytes --]

Re: [mmotm:master 208/394] mm/page_alloc.c:6245:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'zone_init_internals'

[Oscar Salvador]

On Sat, Aug 11, 2018 at 07:00:52PM +0800, kbuild test robot wrote:
> tree:   git://git.cmpxchg.org/linux-mmotm.git master
> head:   b1da01df1aa700864692a49a7007fc96cc1da7d9
> commit: e3dcfdaca81e86f21335a0b6d39162ad574c8574 [208/394] mm/page_alloc: Introduce free_area_init_core_hotplug
> config: x86_64-fedora-25 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         git checkout e3dcfdaca81e86f21335a0b6d39162ad574c8574
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> Note: the mmotm/master HEAD b1da01df1aa700864692a49a7007fc96cc1da7d9 builds fine.
>       It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
> >> mm/page_alloc.c:6245:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'zone_init_internals'
>     static void __paginginit zone_init_internals(struct zone *zone, enum zone_type idx, int nid,
>                              ^~~~~~~~~~~~~~~~~~~
>    mm/page_alloc.c: In function 'free_area_init_core_hotplug':
> >> mm/page_alloc.c:6272:3: error: implicit declaration of function 'zone_init_internals'; did you mean 'pgdat_init_internals'? [-Werror=implicit-function-declaration]
>       zone_init_internals(&pgdat->node_zones[z], z, nid, 0);

It looks like this linux-mmotm's tree is not testing the right version of the patch.
In V6 [1], zone_init_internals is declared as __meminit because the __paginginit macro was just dropped.

I just checked out the last version of the linux-mmotm tree, and it contains the right thing there:

<--
static void __meminit zone_init_internals(struct zone *zone, enum zone_type idx, int nid,
                                                        unsigned long remaining_pages)
{
        zone->managed_pages = remaining_pages;
        zone_set_nid(zone, nid);
        zone->name = zone_names[idx];
        zone->zone_pgdat = NODE_DATA(nid);
-->

So this error looks invalid.


[1] https://patchwork.kernel.org/patch/10552231/
-- 
Oscar Salvador
SUSE L3