From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f198.google.com (mail-qk0-f198.google.com [209.85.220.198]) by kanga.kvack.org (Postfix) with ESMTP id D7E836B026B for ; Thu, 16 Aug 2018 06:06:56 -0400 (EDT) Received: by mail-qk0-f198.google.com with SMTP id m2-v6so3855289qka.9 for ; Thu, 16 Aug 2018 03:06:56 -0700 (PDT) Received: from mx1.redhat.com (mx3-rdu2.redhat.com. [66.187.233.73]) by mx.google.com with ESMTPS id 30-v6si2579993qvt.193.2018.08.16.03.06.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Aug 2018 03:06:56 -0700 (PDT) From: David Hildenbrand Subject: [PATCH v1 5/5] mm/memory_hotplug: print only with DEBUG_VM in online/offline_pages() Date: Thu, 16 Aug 2018 12:06:28 +0200 Message-Id: <20180816100628.26428-6-david@redhat.com> In-Reply-To: <20180816100628.26428-1-david@redhat.com> References: <20180816100628.26428-1-david@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Vlastimil Babka , Stephen Rothwell , Pavel Tatashin , Kemi Wang , David Rientjes , Jia He , Oscar Salvador , Petr Tesarik , Andrey Ryabinin , Dan Williams , David Hildenbrand , Mathieu Malaterre , Baoquan He , Wei Yang , Ross Zwisler , "Kirill A . Shutemov" Let's try to minimze the noise. Signed-off-by: David Hildenbrand --- mm/memory_hotplug.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index bbbd16f9d877..6fec2dc6a73d 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -966,9 +966,11 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ return 0; failed_addition: +#ifdef CONFIG_DEBUG_VM pr_debug("online_pages [mem %#010llx-%#010llx] failed\n", (unsigned long long) pfn << PAGE_SHIFT, (((unsigned long long) pfn + nr_pages) << PAGE_SHIFT) - 1); +#endif memory_notify(MEM_CANCEL_ONLINE, &arg); return ret; } @@ -1660,7 +1662,9 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages) offlined_pages = check_pages_isolated(start_pfn, end_pfn); if (offlined_pages < 0) goto repeat; +#ifdef CONFIG_DEBUG_VM pr_info("Offlined Pages %ld\n", offlined_pages); +#endif /* Ok, all of our target is isolated. We cannot do rollback at this point. */ offline_isolated_pages(start_pfn, end_pfn); @@ -1695,9 +1699,11 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages) return 0; failed_removal: +#ifdef CONFIG_DEBUG_VM pr_debug("memory offlining [mem %#010llx-%#010llx] failed\n", (unsigned long long) start_pfn << PAGE_SHIFT, ((unsigned long long) end_pfn << PAGE_SHIFT) - 1); +#endif memory_notify(MEM_CANCEL_OFFLINE, &arg); /* pushback to free area */ undo_isolate_page_range(start_pfn, end_pfn, MIGRATE_MOVABLE); -- 2.17.1