From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild test robot <lkp@intel.com>
Cc: Jia He <jia.he@hxt-semitech.com>,
kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [mmotm:master 187/242] mm/memblock.c:1290:6: error: 'early_region_idx' undeclared; did you mean 'early_pfn_to_nid'?
Date: Wed, 22 Aug 2018 09:12:33 -0700 [thread overview]
Message-ID: <20180822091233.333b52bd38efcf3f7d86be37@linux-foundation.org> (raw)
In-Reply-To: <201808221909.yuIwBvuo%fengguang.wu@intel.com>
On Wed, 22 Aug 2018 19:37:44 +0800 kbuild test robot <lkp@intel.com> wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: 10b78d76f1897885d7753586ecd113e9d6728c5d
> commit: be2e6e87ac5e7f8f30c442bb1a042266e1ab6fcd [187/242] mm/memblock: introduce pfn_valid_region()
> config: arm-omap2plus_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout be2e6e87ac5e7f8f30c442bb1a042266e1ab6fcd
> # save the attached .config to linux build tree
> GCC_VERSION=7.2.0 make.cross ARCH=arm
>
> All error/warnings (new ones prefixed by >>):
>
> mm/memblock.c: In function 'pfn_valid_region':
> >> mm/memblock.c:1290:6: error: 'early_region_idx' undeclared (first use in this function); did you mean 'early_pfn_to_nid'?
> if (early_region_idx != -1) {
> ^~~~~~~~~~~~~~~~
> early_pfn_to_nid
> mm/memblock.c:1290:6: note: each undeclared identifier is reported only once for each function it appears in
> >> mm/memblock.c:1305:1: warning: control reaches end of non-void function [-Wreturn-type]
> }
oops
--- a/mm/memblock.c~mm-page_alloc-reduce-unnecessary-binary-search-in-memblock_next_valid_pfn-fix-fix
+++ a/mm/memblock.c
@@ -1232,6 +1232,7 @@ int __init_memblock memblock_set_node(ph
#endif /* CONFIG_HAVE_MEMBLOCK_NODE_MAP */
#ifdef CONFIG_HAVE_MEMBLOCK_PFN_VALID
+static int early_region_idx __initdata_memblock = -1;
unsigned long __init_memblock memblock_next_valid_pfn(unsigned long pfn)
{
struct memblock_type *type = &memblock.memory;
@@ -1240,7 +1241,6 @@ unsigned long __init_memblock memblock_n
uint mid, left = 0;
unsigned long start_pfn, end_pfn, next_start_pfn;
phys_addr_t addr = PFN_PHYS(++pfn);
- static int early_region_idx __initdata_memblock = -1;
/* fast path, return pfn+1 if next pfn is in the same region */
if (early_region_idx != -1) {
_
prev parent reply other threads:[~2018-08-22 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 11:37 [mmotm:master 187/242] mm/memblock.c:1290:6: error: 'early_region_idx' undeclared; did you mean 'early_pfn_to_nid'? kbuild test robot
2018-08-22 16:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822091233.333b52bd38efcf3f7d86be37@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jia.he@hxt-semitech.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).