From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f71.google.com (mail-oi0-f71.google.com [209.85.218.71]) by kanga.kvack.org (Postfix) with ESMTP id 94E636B2C96 for ; Thu, 23 Aug 2018 19:27:13 -0400 (EDT) Received: by mail-oi0-f71.google.com with SMTP id l191-v6so6169693oig.23 for ; Thu, 23 Aug 2018 16:27:13 -0700 (PDT) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id n82-v6si4080540oih.318.2018.08.23.16.27.12 for ; Thu, 23 Aug 2018 16:27:12 -0700 (PDT) Date: Fri, 24 Aug 2018 00:27:05 +0100 From: Will Deacon Subject: Re: [RFC PATCH 0/2] minor mmu_gather patches Message-ID: <20180823232704.GA4487@brain-police> References: <20180823084709.19717-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Nick Piggin , Peter Zijlstra , Andrew Lutomirski , the arch/x86 maintainers , Borislav Petkov , Rik van Riel , Jann Horn , Adin Scannell , Dave Hansen , Linux Kernel Mailing List , linux-mm , David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch Hi Linus, On Thu, Aug 23, 2018 at 12:37:58PM -0700, Linus Torvalds wrote: > On Thu, Aug 23, 2018 at 12:15 PM Linus Torvalds > wrote: > > > > So right now my "tlb-fixes" branch looks like this: > > [..] > > > > I'll do a few more test builds and boots, but I think I'm going to > > merge it in this cleaned-up and re-ordered form. > > In the meantime, I decided to push out that branch in case anybody > wants to look at it. > > I may rebase it if I - or anybody else - find anything bad there, so > consider it non-stable, but I think it's in its final shape modulo > issues. Unfortunately, that branch doesn't build for arm64 because of Nick's patch moving tlb_flush_mmu_tlbonly() into tlb.h (which I acked!). It's a static inline which calls tlb_flush(), which in our case is also a static inline but one that is defined in our asm/tlb.h after including asm-generic/tlb.h. Ah, just noticed you've pushed this to master! Please could you take the arm64 patch below on top, in order to fix the build? Cheers, Will --->8